Make sequoia signing work with sequoia-sq >= 0.38 #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequoia-sq 0.38 removed all short options, at least temporarily: https://gitlab.com/sequoia-pgp/sequoia-sq/-/commit/f7ce1fa2a172ae02171a3421bebf2a4aa3cfb8a5 As that version got supplied to Fedora 40 as an update, we started getting intermittent failures where every other CI run failed due to it having the newer version that didn't accept the -o usage we just added in d99186f. What a timing. There's no reason why we couldn't just use the long ones though, it's more readable that way anyhow. Shrug and move on. Fixes: rpm-software-management#3317
pmatilai
requested review from
a team and
dmnks
and removed request for
a team
|
This turned into a nice Friday side quest, indeed 😄 Nice find, anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sequoia-sq 0.38 removed all short options, at least temporarily: https://gitlab.com/sequoia-pgp/sequoia-sq/-/commit/f7ce1fa2a172ae02171a3421bebf2a4aa3cfb8a5
As that version got supplied to Fedora 40 as an update, we started getting intermittent failures where every other CI run failed due to it having the newer version that didn't accept the -o usage we just added in d99186f. What a timing.
There's no reason why we couldn't just use the long ones though, it's more readable that way anyhow. Shrug and move on.
Fixes: #3317