-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to macro syntax page from spec syntax page #3352
Conversation
Now that I look at the placement of the |
Uh, how on earth we didn't have %dnl documented in the macro docs? 😳 It certainly belongs in that table, it's not spec-specific although that's where the most typical usage may be. Putting this into the "Comments" section seems strange. We should have (however brief) section about macros in the syntax, probably as the very first subsection as they're so fundamental to the spec. Maybe something like
|
Ack, I was too lazy and just added plain links but of course, it felt weird because then how do you decide which mentions of "macros" you turn into links... 😅 So yup, having a small, dedicated intro would be much better. I'll fix it up. |
Thanks, I've used your suggestion 😄 Should be fixed now. |
"discard to next line" sounds weird to me. How about "discard rest of the line"? |
The descriptions comes from the original commit that added
That said, unless there's a technical to reason to word it like that, I agree it'd sound more natural to just say "discard rest of the line". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yup, thanks! (re: fixup commits)
OK, one theory as to whether it was worded like that: If you have a multiline macro with the line continuation mark at end of line, you technically have a single logical line, but two (text) lines:
|
Maybe I'm reading too much into it, though, but it does seem like a somewhat important distinction 😄 |
All that theorizing aside, typically when we mention "line" we mean the textual line, and I'm yet to see a language whose syntax interprets such line continuation markers in comments, so yep... I'm reading too much into it 😄 |
The "discard to next line" is a very deliberate wording, because that's what the acronym stands for, and how M4's dnl is described: https://www.gnu.org/software/m4/manual/html_node/Dnl.html, and M4 dnl is what we want people to associate this with 😄 |
I think it's fine as-is, just squash the two spelling fixes to the second commit. |
Right, I had a feeling this must be deliberate 😄 Thanks for confirming. |
This was lost in translation, since commit 015c829, so add it back.
Macros play a rather big role in spec parsing, yet we were missing a word about there being a separate page, how come! Fixes: rpm-software-management#3331
OK, we've had enough of bike shedding on this one, I think, merging now. |
We speak about (built-in) macros and their expansion in various parts of the spec page but never care to actually mention to the reader that there's a dedicated page on macro syntax. Add a bunch of links where appropriate, and since one of those places mentions %dnl, also add %dnl to the macro page (this used to be there, just got missed in the reformatting commit 015c829).
Fixes: #3331