Mass rename C++ sources to .cc/.hh extension #3356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one lone source got overlooked in the initial C++ enablement in commit 37cdcc2. C++ doesn't like jumping over variable declarations, so just move the declarations early to minimally fix the build. Nicely goes to show the danger of such hacks - you can always miss something. On the library side things are likely to blow up in linkage but you never know really.
As planned from the start of the C++ journey, rename all C++ files to a C++ extension to remove the confusion for both humans and tooling - so we now get to remove the associated cmake hacks to force it to use a C++ compiler. We initially decided on going for .cxx/.hxx extension on the grounds that it's the technically most right thing to do as it matches with the build toolchain CXX/CXXFLAGS and all that. But at around 1/4 way through the rename I concluded that this is not only eye-bleeding ugly, it also totally obfuscates the difference between headers and sources in the visual noise it creates. Last but not least, it makes you think of All My Ex's Live in Texas, and that's about the last thing in I want to be thinking off. Both the song, and the exes. Those of us working on rpm for a living need to think of their well-being, both mental and physical. The choice of .cc/.hh extension is primarily based on that: the .cxx/.hxx extension proved to be almost revolting in practise. To my total surprise really, I never expected this to matter at all. Maybe others have had similar feelings though, .cc/.hh is one of the more common choices, for example gcc and binutils use that. Fixes: rpm-software-management#3316
|
The first commit is to fixup the one oversight in the initial c++ work: rpmuncompress was being compiled as C because it wasn't listed as in cxx_sources. Just goes to prove how britle such hacks are - it's better to get this rename over and dealt with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As planned from the start of the C++ journey, rename all C++ files to a C++ extension to remove the confusion for both humans and tooling - so we now get to remove the associated cmake hacks to force it to use a C++ compiler.
We initially decided on going for .cxx/.hxx extension on the grounds that it's the technically most right thing to do as it matches with the build toolchain CXX/CXXFLAGS and all that. But at around 1/4 way through the rename I concluded that this is not only eye-bleeding ugly, it also totally obfuscates the difference between headers and sources in the visual noise it creates. Last but not least, it makes you think of All My Ex's Live in Texas, and that's about the last thing in I want to be thinking off. Both the song, and the exes.
Those of us working on rpm for a living need to think of their well-being, both mental and physical. The choice of .cc/.hh extension is primarily based on that: the .cxx/.hxx extension proved to be almost revolting in practise. To my total surprise really, I never expected this to matter at all. Maybe others have had similar feelings though, .cc/.hh is one of the more common choices, for example gcc and binutils use that.
Fixes: #3316