Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '-.*' from the end of git-annex version strings. #423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pcreech
Copy link

@pcreech pcreech commented Jun 2, 2022

RPMs provided by git-annex have a '-{hash}' added to the version, breaking version detection.

This was the simplest way I could come up with to get around this issue, based on what was already implemented.

RPMs provided by git-annex have a '-{hash}' added to the version, breaking version detection.

This was the simplest way I could come up with to get around this issue, based on what was already implemented.
@pcreech
Copy link
Author

pcreech commented Jun 2, 2022

The git-annex rpm repo I'm using is:

[git-annex]
name=git-annex repository
baseurl=https://downloads.kitenet.net/git-annex/linux/current/rpms/
enabled=0
gpgcheck=0

@pcreech
Copy link
Author

pcreech commented Jun 2, 2022

thinking about it, the removing '-.*' might better belong in the git annex builder, as the version is being passed in.

@FrostyX
Copy link
Member

FrostyX commented Sep 18, 2022

Hello @pcreech,
sorry for the late reply.

I like the PR, and I would keep the change where it is. Can you please add these two asserts into common_tests.py:test_compare_versions?

self.assertEquals(0, compare_version("1.0-abc", "1.0-xyz"))
self.assertTrue(compare_version("1.1-abc", "1.0-xyz"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants