Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify README and index.md #477

Merged
merged 1 commit into from
Jan 4, 2024
Merged

unify README and index.md #477

merged 1 commit into from
Jan 4, 2024

Conversation

xsuchy
Copy link
Member

@xsuchy xsuchy commented Jan 4, 2024

README is in better state - I used that one

@xsuchy
Copy link
Member Author

xsuchy commented Jan 4, 2024

The diff seems to be big, but I just did:

git rm doc/index.md
git mv README.md doc/index.md
ln -s doc/index.md README.md

@xsuchy
unify README and index.md
9f77422 
README is in better state - I used that one
@FrostyX
Copy link
Member

FrostyX commented Jan 4, 2024 •
edited
Loading

In the specfile we have: %doc doc/*

So the index is currently being installed. After this PR it will disappear. Maybe it would be worth it to add %doc README.md?

Edit: I missed the ln -s ...

FrostyX
FrostyX approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@FrostyX FrostyX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thank you for the PR.

@FrostyX FrostyX merged commit 37a8a23 into rpm-software-management:master Jan 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrostyX FrostyX FrostyX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xsuchy @FrostyX