Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<gitroot>/tito wrapper #493

Merged

Conversation

praiskup
Copy link
Member

This makes executing of Tito-from-Git a bit more convenient.

@FrostyX
Copy link
Member

FrostyX commented Feb 23, 2024

I've always been running Tito from git using e.g.

PYTHONPATH=/home/jkadlcik/git/tito/src/ python3 /home/jkadlcik/git/tito/src/tito/cli.py build --rpm

so personally, I don't have a need for the wrapper. If you find it useful, we can merge though. But in that case, please add some docstring at the top of the script discouraging people from using it unless they are working on Tito code.

@praiskup
Copy link
Member Author

PYTHONPATH=/home/jkadlcik/git/tito/src/ python3 /home/jkadlcik/git/tito/src/tito/cli.py build --rpm

I don't claim it I personally need this, but it is just more convenient to just run ./tito.

But in that case, please add some docstring at the top of the script discouraging people from using it

There already is an ugly stderr output, do you prefer doc, the ugly output, or both? (I prefer just one of them)

@FrostyX
Copy link
Member

FrostyX commented Feb 26, 2024

There already is an ugly stderr output, do you prefer doc, the ugly output, or both? (I prefer just one of them)

I don't have a strong preference, it can be either stderr output, docstring, or both. The problem I have with the stderr as it is right now is that the message is cryptic and it doesn't provide any explanation. I would prefer something like

Warning: Running Tito from a git repository is not supported. 
If you are not a developer working on Tito code, please install it properly 
https://github.com/rpm-software-management/tito/blob/master/doc/index.md#install

This makes executing of Tito-from-Git a bit more convenient.
@praiskup
Copy link
Member Author

the message is cryptic and it doesn't provide any explanation

Good point, PTAL

@FrostyX
Copy link
Member

FrostyX commented Feb 27, 2024

Thank you for the changes.

@FrostyX FrostyX merged commit 6d09a79 into rpm-software-management:master Feb 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants