Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Path" from the desktop file #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luk1337
Copy link

@luk1337 luk1337 commented Oct 5, 2024

No idea why but Discord with Vencord installed crashes for me if it's ran from /usr/bin.

Since other desktop files don't set Path, this is safe to remove anyway.

No idea why but Discord with Vencord installed crashes for me if it's
ran from /usr/bin.

Since other desktop files don't set Path, this is safe to remove anyway.
@kwizart
Copy link
Member

kwizart commented Oct 5, 2024

Can you show a stacktrace ? I could be unrelated or still is questionable fix for a crash.

@luk1337
Copy link
Author

luk1337 commented Oct 5, 2024

Can you show a stacktrace ? I could be unrelated or still is questionable fix for a crash.

I'm aware that the fix is questionable, but given that rg ^Path /usr/share/applications had just discord.desktop using it, I think it's harmless regardless of the actual reason.

$ ./Discord
Disabling updates already done
[Vencord] Starting up...
[Vencord] Loading original Discord app.asar
Discord 0.0.70
Starting app.
Starting updater.
2024-10-05T19:03:41.209Z [Modules] Modules initializing
2024-10-05T19:03:41.209Z [Modules] Distribution: remote
2024-10-05T19:03:41.209Z [Modules] Host updates: disabled
2024-10-05T19:03:41.209Z [Modules] Module updates: enabled
2024-10-05T19:03:41.210Z [Modules] Module install path: /home/luk/.config/discord/0.0.70/modules
2024-10-05T19:03:41.210Z [Modules] Module installed file path: /home/luk/.config/discord/0.0.70/modules/installed.json
2024-10-05T19:03:41.210Z [Modules] Module download path: /home/luk/.config/discord/0.0.70/modules/pending
splashScreen.initSplash(false)
CDM component API found
blackbox: 2024-10-05T19:03:41.289Z 0 

----------------------------------------------
CDM completed with status: cdm-ready-success
blackbox: 2024-10-05T19:03:41.296Z 1 Discord starting: {"releaseChannel":"stable","version":"0.0.70"}, modulepath: /home/luk/.config/discord/0.0.70/modules
blackbox: 2024-10-05T19:03:41.301Z 2 ✅ webContents.created web1 "index.html"
blackbox: 2024-10-05T19:03:41.302Z 3 ✅ window.created win1 "discord"
splashScreen: SPLASH_SCREEN_READY
splashScreen.webContentsSend: SPLASH_SCREEN_QUOTE SPLASH_SCREEN_QUOTE [ 'Hold Tight — Loading Discord' ]
2024-10-05T19:03:41.368Z [Modules] No updates to install
splashScreen: no-pending-updates
2024-10-05T19:03:41.369Z [Modules] Host is up to date.
2024-10-05T19:03:41.369Z [Modules] Checking for module updates at https://discord.com/api/modules/stable/versions.json
splashScreen: checking-for-updates
splashScreen.updateSplashState checking-for-updates checking-for-updates {}
splashScreen.webContentsSend: SPLASH_UPDATE_STATE SPLASH_UPDATE_STATE [ { status: 'checking-for-updates' } ]
2024-10-05T19:03:41.376Z [Modules] No module updates available.
splashScreen: update-check-finished true 0 false
splashScreen.launchMainWindow: false
Optional module ./ElectronTestRpc was not included.
splashScreen.updateSplashState launching launching {}
splashScreen.webContentsSend: SPLASH_UPDATE_STATE SPLASH_UPDATE_STATE [ { status: 'launching' } ]
blackbox: 2024-10-05T19:03:41.416Z 4 ✅ webContents.created web2 ""
blackbox: 2024-10-05T19:03:41.422Z 5 ✅ window.created win2 "Discord"
blackbox: 2024-10-05T19:03:41.426Z 6 ✅ webContents.did-finish-load web1
[WebContents] crashed (reason: crashed, exitCode: 134)... reloading
Optional module ./ElectronTestRpc was not included.
blackbox: 2024-10-05T19:03:44.652Z 7 ❌ render-process-gone { reason: 'crashed', exitCode: 134 }
blackbox: 2024-10-05T19:03:44.660Z 8 window.closed win2
blackbox: 2024-10-05T19:03:44.663Z 9 ✅ webContents.created web3 ""
blackbox: 2024-10-05T19:03:44.673Z 10 ✅ window.created win3 "Discord"
blackbox: 2024-10-05T19:03:44.675Z 11 webContents.destroyed web2
[350679:1005/210344.725111:ERROR:interface_endpoint_client.cc(722)] Message 0 rejected by interface blink.mojom.WidgetHost
[WebContents] double crashed (reason: crashed, exitCode: 134)... RIP =(
notificationScreen.webContentsSend: win is invalid undefined.
blackbox: 2024-10-05T19:03:47.656Z 12 ❌ render-process-gone { reason: 'crashed', exitCode: 134 }
blackbox: 2024-10-05T19:03:47.661Z 13 before-quit
Oct 05 21:03:47 luk-pc systemd-coredump[350986]: [🡕] Process 350917 (Discord) of user 1000 dumped core.
                                                 
                                                 Module /home/luk/.config/discord/0.0.70/modules/discord_utils/node_modules/macos-notification-state/build/Release/notificationstate.node without build-id.
                                                 Module libmpg123.so.0 from rpm mpg123-1.31.3-5.fc41.x86_64
                                                 Module libogg.so.0 from rpm libogg-1.3.5-9.fc41.x86_64
                                                 Module libopus.so.0 from rpm opus-1.5.2-1.fc41.x86_64
                                                 Module libvorbisenc.so.2 from rpm libvorbis-1.3.7-11.fc41.x86_64
                                                 Module libvorbis.so.0 from rpm libvorbis-1.3.7-11.fc41.x86_64
                                                 Module libFLAC.so.12 from rpm flac-1.4.3-5.fc41.x86_64
                                                 Module libgsm.so.1 from rpm gsm-1.0.22-7.fc41.x86_64
                                                 Module libsndfile.so.1 from rpm libsndfile-1.2.2-4.fc41.x86_64
                                                 Module libpulsecommon-17.0.so from rpm pulseaudio-17.0-2.fc41.x86_64
                                                 Module libpulse.so.0 from rpm pulseaudio-17.0-2.fc41.x86_64
                                                 Module libXss.so.1 from rpm libXScrnSaver-1.2.4-4.fc41.x86_64
                                                 Module libtinfo.so.6 from rpm ncurses-6.5-2.20240629.fc41.x86_64
                                                 Module libpciaccess.so.0 from rpm libpciaccess-0.16-13.fc41.x86_64
                                                 Module libedit.so.0 from rpm libedit-3.1-53.20240808cvs.fc41.x86_64
                                                 Module libbrotlicommon.so.1 from rpm brotli-1.1.0-5.fc41.x86_64
                                                 Module liblzma.so.5 from rpm xz-5.6.2-2.fc41.x86_64
                                                 Module libxcb-dri2.so.0 from rpm libxcb-1.17.0-3.fc41.x86_64
                                                 Module libdrm_intel.so.1 from rpm libdrm-2.4.123-1.fc41.x86_64
                                                 Module libdrm_amdgpu.so.1 from rpm libdrm-2.4.123-1.fc41.x86_64
                                                 Module libelf.so.1 from rpm elfutils-0.191-8.fc41.x86_64
                                                 Module libdrm_radeon.so.1 from rpm libdrm-2.4.123-1.fc41.x86_64
                                                 Module libsensors.so.4 from rpm lm_sensors-3.6.0-20.fc41.x86_64
                                                 Module libxshmfence.so.1 from rpm libxshmfence-1.3.2-4.fc41.x86_64
                                                 Module libxcb-sync.so.1 from rpm libxcb-1.17.0-3.fc41.x86_64
                                                 Module libxcb-xfixes.so.0 from rpm libxcb-1.17.0-3.fc41.x86_64
                                                 Module libxcb-present.so.0 from rpm libxcb-1.17.0-3.fc41.x86_64
                                                 Module libxcb-dri3.so.0 from rpm libxcb-1.17.0-3.fc41.x86_64
                                                 Module libX11-xcb.so.1 from rpm libX11-1.8.10-2.fc41.x86_64
                                                 Module libzstd.so.1 from rpm zstd-1.5.6-2.fc41.x86_64
                                                 Module libglapi.so.0 from rpm mesa-24.2.3-4.fc41.x86_64
                                                 Module libbrotlidec.so.1 from rpm brotli-1.1.0-5.fc41.x86_64
                                                 Module libbz2.so.1 from rpm bzip2-1.0.8-19.fc41.x86_64
                                                 Module libdatrie.so.1 from rpm libdatrie-0.2.13-10.fc41.x86_64
                                                 Module libjson-glib-1.0.so.0 from rpm json-glib-1.10.0-1.fc41.x86_64
                                                 Module libjpeg.so.62 from rpm libjpeg-turbo-3.0.2-3.fc41.x86_64
                                                 Module libxml2.so.2 from rpm libxml2-2.12.8-2.fc41.x86_64
                                                 Module libgraphite2.so.3 from rpm graphite2-1.3.14-16.fc41.x86_64
                                                 Module libXinerama.so.1 from rpm libXinerama-1.1.5-7.fc41.x86_64
                                                 Module libXcursor.so.1 from rpm libXcursor-1.2.2-2.fc41.x86_64
                                                 Module libwayland-egl.so.1 from rpm wayland-1.23.0-2.fc41.x86_64
                                                 Module libwayland-cursor.so.0 from rpm wayland-1.23.0-2.fc41.x86_64
                                                 Module libgmp.so.10 from rpm gmp-6.3.0-2.fc41.x86_64
                                                 Module libhogweed.so.6 from rpm nettle-3.10-3.fc41.x86_64
                                                 Module libnettle.so.8 from rpm nettle-3.10-3.fc41.x86_64
                                                 Module libtasn1.so.6 from rpm libtasn1-4.19.0-9.fc41.x86_64
                                                 Module libunistring.so.5 from rpm libunistring-1.1-8.fc41.x86_64
                                                 Module libidn2.so.0 from rpm libidn2-2.3.7-2.fc41.x86_64
                                                 Module libp11-kit.so.0 from rpm p11-kit-0.25.5-3.fc41.x86_64
                                                 Module libcrypto.so.3 from rpm openssl-3.2.2-9.fc41.x86_64
                                                 Module libkeyutils.so.1 from rpm keyutils-1.6.3-4.fc41.x86_64
                                                 Module libkrb5support.so.0 from rpm krb5-1.21.3-2.fc41.x86_64
                                                 Module libcom_err.so.2 from rpm e2fsprogs-1.47.1-3.fc41.x86_64
                                                 Module libk5crypto.so.3 from rpm krb5-1.21.3-2.fc41.x86_64
                                                 Module libkrb5.so.3 from rpm krb5-1.21.3-2.fc41.x86_64
                                                 Module libcap.so.2 from rpm libcap-2.70-4.fc41.x86_64
                                                 Module libblkid.so.1 from rpm util-linux-2.40.2-4.fc41.x86_64
                                                 Module libXau.so.6 from rpm libXau-1.0.11-7.fc41.x86_64
                                                 Module libxcb-randr.so.0 from rpm libxcb-1.17.0-3.fc41.x86_64
                                                 Module libwayland-server.so.0 from rpm wayland-1.23.0-2.fc41.x86_64
                                                 Module libgallium-24.2.3.so from rpm mesa-24.2.3-4.fc41.x86_64
                                                 Module libpixman-1.so.0 from rpm pixman-0.43.4-2.fc41.x86_64
                                                 Module libxcb-shm.so.0 from rpm libxcb-1.17.0-3.fc41.x86_64
                                                 Module libxcb-render.so.0 from rpm libxcb-1.17.0-3.fc41.x86_64
                                                 Module libXrender.so.1 from rpm libXrender-0.9.11-7.fc41.x86_64
                                                 Module libfreetype.so.6 from rpm freetype-2.13.2-6.fc41.x86_64
                                                 Module libpng16.so.16 from rpm libpng-1.6.40-4.fc41.x86_64
                                                 Module libthai.so.0 from rpm libthai-0.1.29-9.fc41.x86_64
                                                 Module libwayland-client.so.0 from rpm wayland-1.23.0-2.fc41.x86_64
                                                 Module libtracker-sparql-3.0.so.0 from rpm tracker-3.7.3-3.fc41.x86_64
                                                 Module libcloudproviders.so.0 from rpm libcloudproviders-0.3.5-5.fc41.x86_64
                                                 Module libXi.so.6 from rpm libXi-1.8.2-1.fc41.x86_64
                                                 Module libepoxy.so.0 from rpm libepoxy-1.5.10-8.fc41.x86_64
                                                 Module libgdk_pixbuf-2.0.so.0 from rpm gdk-pixbuf2-2.42.12-6.fc41.x86_64
                                                 Module libcairo-gobject.so.2 from rpm cairo-1.18.0-4.fc41.x86_64
                                                 Module libfribidi.so.0 from rpm fribidi-1.0.15-2.fc41.x86_64
                                                 Module libfontconfig.so.1 from rpm fontconfig-2.15.0-8.fc41.x86_64
                                                 Module libpangoft2-1.0.so.0 from rpm pango-1.54.0-2.fc41.x86_64
                                                 Module libharfbuzz.so.0 from rpm harfbuzz-9.0.0-3.fc41.x86_64
                                                 Module libpangocairo-1.0.so.0 from rpm pango-1.54.0-2.fc41.x86_64
                                                 Module libgdk-3.so.0 from rpm gtk3-3.24.43-2.fc41.x86_64
                                                 Module libgnutls.so.30 from rpm gnutls-3.8.6-7.fc41.x86_64
                                                 Module libavahi-client.so.3 from rpm avahi-0.8-29.fc41.x86_64
                                                 Module libavahi-common.so.3 from rpm avahi-0.8-29.fc41.x86_64
                                                 Module libgssapi_krb5.so.2 from rpm krb5-1.21.3-2.fc41.x86_64
                                                 Module libsystemd.so.0 from rpm systemd-256.6-1.fc41.x86_64
                                                 Module libplds4.so from rpm nss-3.104.0-1.fc41.x86_64
                                                 Module libplc4.so from rpm nss-3.104.0-1.fc41.x86_64
                                                 Module libselinux.so.1 from rpm libselinux-3.7-5.fc41.x86_64
                                                 Module libmount.so.1 from rpm util-linux-2.40.2-4.fc41.x86_64
                                                 Module libz.so.1 from rpm zlib-ng-2.1.7-3.fc41.x86_64
                                                 Module libgmodule-2.0.so.0 from rpm glib2-2.82.1-1.fc41.x86_64
                                                 Module libpcre2-8.so.0 from rpm pcre2-10.44-1.fc41.1.x86_64
                                                 Module libffi.so.8 from rpm libffi-3.4.6-3.fc41.x86_64
                                                 Module libatspi.so.0 from rpm at-spi2-core-2.54.0-1.fc41.x86_64
                                                 Module libasound.so.2 from rpm alsa-lib-1.2.12-2.fc41.x86_64
                                                 Module libxkbcommon.so.0 from rpm libxkbcommon-1.7.0-4.fc41.x86_64
                                                 Module libxcb.so.1 from rpm libxcb-1.17.0-3.fc41.x86_64
                                                 Module libexpat.so.1 from rpm expat-2.6.3-1.fc41.x86_64
                                                 Module libgbm.so.1 from rpm mesa-24.2.3-4.fc41.x86_64
                                                 Module libXrandr.so.2 from rpm libXrandr-1.5.4-4.fc41.x86_64
                                                 Module libXfixes.so.3 from rpm libXfixes-6.0.1-4.fc41.x86_64
                                                 Module libXext.so.6 from rpm libXext-1.3.6-2.fc41.x86_64
                                                 Module libXdamage.so.1 from rpm libXdamage-1.1.6-4.fc41.x86_64
                                                 Module libXcomposite.so.1 from rpm libXcomposite-0.4.6-4.fc41.x86_64
                                                 Module libX11.so.6 from rpm libX11-1.8.10-2.fc41.x86_64
                                                 Module libcairo.so.2 from rpm cairo-1.18.0-4.fc41.x86_64
                                                 Module libpango-1.0.so.0 from rpm pango-1.54.0-2.fc41.x86_64
                                                 Module libgtk-3.so.0 from rpm gtk3-3.24.43-2.fc41.x86_64
                                                 Module libdrm.so.2 from rpm libdrm-2.4.123-1.fc41.x86_64
                                                 Module libcups.so.2 from rpm cups-2.4.10-7.fc41.x86_64
                                                 Module libatk-bridge-2.0.so.0 from rpm at-spi2-core-2.54.0-1.fc41.x86_64
                                                 Module libatk-1.0.so.0 from rpm at-spi2-core-2.54.0-1.fc41.x86_64
                                                 Module libdbus-1.so.3 from rpm dbus-1.14.10-4.fc41.x86_64
                                                 Module libnspr4.so from rpm nss-3.104.0-1.fc41.x86_64
                                                 Module libsmime3.so from rpm nss-3.104.0-1.fc41.x86_64
                                                 Module libnssutil3.so from rpm nss-3.104.0-1.fc41.x86_64
                                                 Module libnss3.so from rpm nss-3.104.0-1.fc41.x86_64
                                                 Module libgio-2.0.so.0 from rpm glib2-2.82.1-1.fc41.x86_64
                                                 Module libglib-2.0.so.0 from rpm glib2-2.82.1-1.fc41.x86_64
                                                 Module libgobject-2.0.so.0 from rpm glib2-2.82.1-1.fc41.x86_64
                                                 Stack trace of thread 350917:
                                                 #0  0x00007f8709d63724 __pthread_kill_implementation (libc.so.6 + 0x72724)
                                                 #1  0x00007f8709d0ad0e raise (libc.so.6 + 0x19d0e)
                                                 #2  0x00007f8709cf2942 abort (libc.so.6 + 0x1942)
                                                 #3  0x00007f86ebf6e3c3 n/a (/home/luk/.config/discord/0.0.70/modules/discord_utils/discord_utils.node + 0x643c3)
                                                 ELF object binary architecture: AMD x86-64

@kwizart
Copy link
Member

kwizart commented Oct 7, 2024

So it should be reproducible by having the Vencord mod installed ?
@sergiomb2 can you reproduce ?

@sergiomb2
Copy link
Contributor

what is Vencord ?

@luk1337
Copy link
Author

luk1337 commented Oct 7, 2024

So it should be reproducible by having the Vencord mod installed ? @sergiomb2 can you reproduce ?

I can't reproduce it on up-to-date rawhide iso, so it's something related to my installation, but I still think this patch is harmless and maybe will help someone other than me too.

what is Vencord ?

https://github.com/Vendicated/Vencord

@sergiomb2
Copy link
Contributor

idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants