Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point to the main branch #2

Merged
merged 1 commit into from
Jul 2, 2023
Merged

point to the main branch #2

merged 1 commit into from
Jul 2, 2023

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Jun 30, 2023

Close pola-rs/r-polars#90

r-polars now supports Rust stable toolchain.

@eitsupi eitsupi requested a review from sorhawell June 30, 2023 02:47
@eitsupi
Copy link
Member Author

eitsupi commented Jun 30, 2023

It does not support the Rust version on R-universe builder yet. (pola-rs/r-polars#208)

@eitsupi eitsupi marked this pull request as draft June 30, 2023 02:50
@eitsupi eitsupi marked this pull request as ready for review June 30, 2023 04:16
@sorhawell
Copy link
Member

It does not support the Rust version on R-universe builder yet. (pola-rs/r-polars#208)

ah yes how would we deal with that?

I will try to add something like this

[profile.release.package.argminmax] + cfg("rust-version"=="1.65.0")
opt-level = 1

@sorhawell sorhawell self-assigned this Jun 30, 2023
@eitsupi
Copy link
Member Author

eitsupi commented Jul 2, 2023

The main branch supports Rust 1.65 now.

@eitsupi eitsupi merged commit 513bacd into main Jul 2, 2023
@eitsupi eitsupi deleted the eitsupi-patch-1 branch July 2, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants