Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll forward: "Detect when the kernel multiplexed hw counters." #2423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Roll forward: "Detect when the kernel multiplexed hw counters." #2423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/PerfCounters.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,25 @@ static const uint64_t IN_TX = 1ULL << 32;
static const uint64_t IN_TXCP = 1ULL << 33;

static int64_t read_counter(ScopedFd& fd) {
int64_t val;
ssize_t nread = read(fd, &val, sizeof(val));
DEBUG_ASSERT(nread == sizeof(val));
return val;
struct read_format {
int64_t value;
int64_t time_enabled;
int64_t time_running;
} data;
errno = 0;
ssize_t nread = read(fd, &data, sizeof(data));
if (nread < 0) {
FATAL() << "Failed to read counter";
}
DEBUG_ASSERT(nread == sizeof(data));
if (data.time_enabled != data.time_running) {
FATAL()
<< "\nCounter was multiplexed to a ratio of "
<< (data.time_running * 1.0 / data.time_enabled)
<< ".\nCheck that other software is not using performance counters on\n"
"this CPU.";
}
return data.value;
}

static ScopedFd start_counter(pid_t tid, int group_fd,
Expand All @@ -283,6 +298,9 @@ static ScopedFd start_counter(pid_t tid, int group_fd,
*disabled_txcp = false;
}
attr->pinned = group_fd == -1;
// Needed to detect when the kernel is multiplexing counters.
attr->read_format =
PERF_FORMAT_TOTAL_TIME_ENABLED | PERF_FORMAT_TOTAL_TIME_RUNNING;
int fd = syscall(__NR_perf_event_open, attr, tid, -1, group_fd, 0);
if (0 >= fd && errno == EINVAL && attr->type == PERF_TYPE_RAW &&
(attr->config & IN_TXCP)) {
Expand Down