Fix adapt css with split #1600
Open
Fix adapt css with split #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 37f5371 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
reviewed
Dec 5, 2024
eoghanmurray
force-pushed
the
fixAdaptCssWithSplit
branch
from
4f056fa to
ec2da5c
Compare
…describeNode` error was encountered. I assume the description `resolveNode` got changed to `describeNode` at some point in puppeteer history; in any case this solves the following error on my laptop: ProtocolError: Protocol error (DOM.describeNode): Cannot find context with specified id with test cross-origin-iframes.test.ts - should replace the existing DOM nodes on iframe navigation with `isAttachIframe`
…n `ix_start` was bigger than zero. Also impose an upper bound of 30 iterations on these substring searches
This reverts commit 0e812f9.
…ations with multiple child nodes and replay them correctly' test to fail. I haven't looked into things more deeply than that the test was complaining about missing .length after `replayer.pause(1000);`
eoghanmurray
force-pushed
the
fixAdaptCssWithSplit
branch
from
f11939f to
eb958c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1575
Thanks @otan for the excellent bug report and test ready to go