-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add method to get event fields inside a Hook #682
base: master
Are you sure you want to change the base?
Conversation
Thanks for the quick review @ccoVeille, followed up with the suggestions and added more tests. Also please see the comment about the tradeoff of using JSON Decode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the changes, here are a few more feedbacks
Co-authored-by: ccoVeille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤞
@ccoVeille @erezrokah I'd also be very happy to have this feature merged, I happened to find this PR looking for a solution. |
I following #637 (comment) as not to expose the internal |
It would be great to merge this if possible so that we don't have to use reflection to work around this. |
Hello, it has been a while. Would it be possible to merge this PR? |
Hi 👋 Thank you for this great module 🚀
Opening for feedback as an attempt to fix #493, #587, also referenced from https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5918/files#diff-a9b82897838da6b8eed398e03c9590621e6c2336ff576b3a49fb684ff8bba2a1R110
This is not the cleanest approach, but could be better from using reflection. It doesn't expose the internal buffer representation format so if it ever changes
GetFields
can be modified.Feedback very much welcomed