Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted #141

Closed
wants to merge 11 commits into from
Closed

Deleted #141

wants to merge 11 commits into from

Conversation

jonathan-dove
Copy link

Allows for key bumps to be added to layout designs through the bool $layout_key_bump being set to true and the the keys which should receive the key bump being in the list $layout_bump_keys = ["F","f","J","j"];

ogaskell and others added 10 commits March 25, 2021 15:16
Legends still need tweaking as they overrun a lot of keys, and the profile is completely wrong as it seems to be doing 1-2-3-4-4-5 instead of 1-1-2-3-4-4.
This allows the size of legends to be modified. For example, on the TKL layout, many of the nav key's legends are too long to fit on a 1u key with the standard 6 font size, so the legend_sizes allows a change of this.

The array specifies differences from the default, so that if the default is adjusted the changed font sizes will be too. For example, +2 means a 2 unit larger legend, 0 means default and -1 means 1 unit smaller.
Not sure how to do vertical keys using layout(), so they've been replaced by 2 keys with the same legend.
@jonathan-dove jonathan-dove marked this pull request as draft February 20, 2022 21:52
@jonathan-dove jonathan-dove changed the title Add Key Bump for Layouts Implement Dual Legends on the Top of Keys and Add Key Bump for Layouts Feb 20, 2022
@jonathan-dove
Copy link
Author

Sorry for the merged pr's but github and I don't get along that well.

@jonathan-dove
Copy link
Author

Added Dual Legend support for the Top so that you can have multiple legends on the top of the key for specialty keys.
full_size_dual implementation is dependent on pr/#96 from @ogaskell. In the default.scad, I utilize a cleaner(at least IMOH) implementation of the growing amount of tables that full_size(#96) introduced. Each Key is defined in a single list held within a row list within the layout list. This makes it easy to corelate the legend to the horizontal/vertical size and font change values. The layout then utilizes list comprehension to separate all the values into individual lists for passing to layout().

@jonathan-dove jonathan-dove marked this pull request as ready for review February 20, 2022 22:12
@jonathan-dove jonathan-dove changed the title Implement Dual Legends on the Top of Keys and Add Key Bump for Layouts Deleted Feb 21, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants