Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazing project! It's wonderful to work with.
I'm building off the work of @kelvie (#87) to implement the XDA keycap style, since I needed them for a project of mine.
I have a set XDA keycaps and calipers, so here's all the info:
The measurements I took. The keycaps are cheaply made and dimensions (especially the width of the keycap's base) varied from part to part. Some of these features (like the rounded corners) were difficult to measure accurately as well, so these are all the best approximations I could make.
The rendered keycap & keycap from which I took measurements.
Since XDA keycaps are all uniform as far as I know I've fixed the tilt and height to constant values regardless of the given row/column in the
xda_row
function. Yet it feels weird disregarding the givenrow
andcolumn
to the function.