Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runes second series doc #140

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

wise4rmgodroot
Copy link
Collaborator

This section of the Runes series covers the following:

  1. Airdrop machine intro
  2. Set up
  3. Deploy using Remix IDE
  4. Template repo code explanation

Copy link

vercel bot commented Nov 1, 2024

@wise4rmgodroot is attempting to deploy a commit to the IOV Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devportal-rootstock ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 3:18pm

Copy link
Collaborator

@owans owans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly reorganize into /resources/guides/runes. It should follow through from the previous tutorial on deploying a runes smart contract

I reorganized the order of the Airdrop machine to be under the Runes.
@wise4rmgodroot
Copy link
Collaborator Author

I have reorganized it.

---
sidebar_position: 2
title: Setup
sidebar_label: Setup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sidebar_label: Setup
sidebar_label: Setup Airdrop Engine

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below you suggested Deploy to be Airdrop Machineand thisAirdrop EngineI used JustSetupandDeploy` because its duplicate with the top title, and i only changed the sidebar title which will not affect SEO

docs/04-resources/08-runes/airdrop/airdrop-setup.md Outdated Show resolved Hide resolved
---
sidebar_position: 3
title: Deploying the Airdrop Machine Smart Contract Using Remix IDE
sidebar_label: Deploy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sidebar_label: Deploy
sidebar_label: Deploy Airdrop Machine

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the setup comment

description: "This guide will walk you through deploying the Airdrop Machine smart contract using Remix IDE. The Airdrop Machine is designed to distribute tokens across multiple addresses, supporting both standard and Merkle tree-based airdrops.
"
---
This section will walk you through deploying the Airdrop Machine smart contract using Remix IDE. The Airdrop Machine is designed to distribute tokens across multiple addresses, supporting both standard and Merkle tree-based airdrops.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This section will walk you through deploying the Airdrop Machine smart contract using Remix IDE. The Airdrop Machine is designed to distribute tokens across multiple addresses, supporting both standard and Merkle tree-based airdrops.
In this section, we will deploy the Airdrop Machine smart contract using Remix IDE. The Airdrop Machine is designed to distribute tokens across multiple addresses, supporting both standard and Merkle tree-based airdrops.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merkle tree was explained right? Link to the explanation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the word we, means we are there with the readers which is not possible (which means we are deploying alongside them).
This is a first person pronoun we should generally be avoided because its an unclear reference and readers dont know who we refers to.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second person pronoun You is preferred or left the way it is as it is not wrong.

docs/04-resources/08-runes/airdrop/deploy.md Outdated Show resolved Hide resolved
---
sidebar_position: 3
title: Deploy Runes Mock Bridge Smart Contract
sidebar_label: Deploy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sidebar_label: Deploy
sidebar_label: Deploy the Mock Bridge Contract

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the setup comment

docs/04-resources/08-runes/mockbridge/runes-deployment.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants