-
Notifications
You must be signed in to change notification settings - Fork 6
feat(storage): adds buying storage capability #351
Conversation
947210e
to
d4afb03
Compare
2bb4d92
to
98f296e
Compare
to its own context squash: splits context state
98f296e
to
ec754fd
Compare
- adds dropzone package
to its own context squash: splits context state
- adds dropzone package
2b5616f
to
964875a
Compare
- this is not advised but it wont work without it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! My review is still in progress but I just left a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy reviewing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pointed some details but overall the amount of work of this PR is impressive 🙂
src/components/atoms/RoundBtn.tsx
Outdated
} from '@material-ui/core' | ||
import { Button } from '@rsksmart/rif-ui' | ||
|
||
export type RoundBtnProps = Omit<ButtonProps, 'color' | 'variant' | 'rounded'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rounded
prop doens't exist in MUI ButtonProps, it's an addition of RIFButton
Works in general. There is the known issue with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(storage): enables order in offersPage * feat: adds new card + grid components * feat: creates required components * feat: uploadPinCard corse * feat: starts plan config * fix(storage): fixes billingPlan currency type * feat: adds plan config card details * feat(storage): adds null check to buy checkout * feat(storage): extracts planOption + rifSelect tsx * feat(storage): extracts offers checkout state to its own context squash: splits context state * feat: extracts pinner and config cards - adds dropzone package * feat: adds size units to pinning * fix: linter fix * feat: improves styles * feat(storage): enables order in offersPage * feat: adds new card + grid components * feat: creates required components * feat: uploadPinCard corse * feat: starts plan config * fix(storage): fixes billingPlan currency type * feat: adds plan config card details * feat(storage): adds null check to buy checkout * feat(storage): extracts planOption + rifSelect tsx * feat(storage): extracts offers checkout state to its own context squash: splits context state * feat: extracts pinner and config cards - adds dropzone package * feat: adds size units to pinning * fix: linter fix * feat: improves styles * feat: adds createAgreement action * squashme: post merge changes * fix: removes cleanup - the cleanup introduced in myOffers PR breaks usability of the CheckoutContext! * feat: adds progress and success views * fix: adds plans check * fix: adds webpack (again) - this is not advised but it wont work without it * refactor: addresses ito's comments * refactor: removes unnecessary cmpnnt * refactor: removes storage specific LabelWValue * refactor: limits price amounts * refactor: fixes checkout context * refactor: removes unused cmpnnt * refactor: - * refactor: adds round button * refactor: styles * refactor: splits and moves checkout context * fix: doesnt go done on reject * refactor: extractions Co-authored-by: Juraj Piar <[email protected]>
Resolves Buy Storage (Main - Hash