Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

feat(storage): adds buying storage capability #351

Merged
merged 49 commits into from
Oct 5, 2020

Conversation

jurajpiar
Copy link
Member

@jurajpiar jurajpiar changed the title feat(storage): enables order in offersPage feat(storage): adds buying storage capability Sep 8, 2020
@jurajpiar jurajpiar force-pushed the feature/purchaseStorage branch 2 times, most recently from 2bb4d92 to 98f296e Compare September 24, 2020 11:18
to its own context

squash: splits context state
@jurajpiar jurajpiar marked this pull request as ready for review October 1, 2020 15:02
Copy link
Contributor

@itofarina itofarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! My review is still in progress but I just left a few comments

src/components/atoms/GridColumn.tsx Outdated Show resolved Hide resolved
src/components/atoms/GridRow.tsx Outdated Show resolved Hide resolved
src/components/molecules/DropZone.tsx Outdated Show resolved Hide resolved
src/components/molecules/storage/buy/LabelWithValue.tsx Outdated Show resolved Hide resolved
src/components/molecules/storage/buy/PinEnterInfoTab.tsx Outdated Show resolved Hide resolved
src/components/molecules/storage/buy/PinEnterInfoTab.tsx Outdated Show resolved Hide resolved
src/components/molecules/storage/buy/PinUploaderTab.tsx Outdated Show resolved Hide resolved
src/components/molecules/storage/buy/RifSelect.tsx Outdated Show resolved Hide resolved
src/components/organisms/RifCard.tsx Outdated Show resolved Hide resolved
src/components/organisms/RifCard.tsx Outdated Show resolved Hide resolved
Copy link
Member Author

@jurajpiar jurajpiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy reviewing!

Copy link
Contributor

@itofarina itofarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pointed some details but overall the amount of work of this PR is impressive 🙂

} from '@material-ui/core'
import { Button } from '@rsksmart/rif-ui'

export type RoundBtnProps = Omit<ButtonProps, 'color' | 'variant' | 'rounded'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rounded prop doens't exist in MUI ButtonProps, it's an addition of RIFButton

src/components/molecules/storage/buy/PinEnterInfoTab.tsx Outdated Show resolved Hide resolved
src/components/molecules/storage/buy/PlanOption.tsx Outdated Show resolved Hide resolved
src/components/organisms/RifCard.tsx Outdated Show resolved Hide resolved
src/components/organisms/storage/buy/StoragePinTabs.tsx Outdated Show resolved Hide resolved
src/components/pages/storage/buy/CheckoutContext.tsx Outdated Show resolved Hide resolved
@julianmrodri
Copy link
Contributor

Works in general. There is the known issue with the size which is not reducing by the correct amount but we will track in separate issue.

Copy link
Contributor

@julianmrodri julianmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurajpiar jurajpiar merged commit d1a29c1 into master Oct 5, 2020
@jurajpiar jurajpiar deleted the feature/purchaseStorage branch October 5, 2020 14:51
itofarina pushed a commit that referenced this pull request Oct 7, 2020
* feat(storage): enables order in offersPage

* feat: adds new card + grid components

* feat: creates required components

* feat: uploadPinCard corse

* feat: starts plan config

* fix(storage): fixes billingPlan currency type

* feat: adds plan config card details

* feat(storage): adds null check to buy checkout

* feat(storage): extracts planOption + rifSelect tsx

* feat(storage): extracts offers checkout state
to its own context

squash: splits context state

* feat: extracts pinner and config cards
- adds dropzone package

* feat: adds size units to pinning

* fix: linter fix

* feat: improves styles

* feat(storage): enables order in offersPage

* feat: adds new card + grid components

* feat: creates required components

* feat: uploadPinCard corse

* feat: starts plan config

* fix(storage): fixes billingPlan currency type

* feat: adds plan config card details

* feat(storage): adds null check to buy checkout

* feat(storage): extracts planOption + rifSelect tsx

* feat(storage): extracts offers checkout state
to its own context

squash: splits context state

* feat: extracts pinner and config cards
- adds dropzone package

* feat: adds size units to pinning

* fix: linter fix

* feat: improves styles

* feat: adds createAgreement action

* squashme: post merge changes

* fix: removes cleanup
- the cleanup introduced in myOffers PR breaks usability
of the CheckoutContext!

* feat: adds progress and success views

* fix: adds plans check

* fix: adds webpack (again)
- this is not advised but it wont work without it

* refactor: addresses ito's comments

* refactor: removes unnecessary cmpnnt

* refactor: removes storage specific LabelWValue

* refactor: limits price amounts

* refactor: fixes checkout context

* refactor: removes unused cmpnnt

* refactor: -

* refactor: adds round button

* refactor: styles

* refactor: splits and moves checkout context

* fix: doesnt go done on reject

* refactor: extractions

Co-authored-by: Juraj Piar <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants