Fix issues with character variants and stylistic sets #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issues with enabling certain character variants (cv05, cv08, cv10, cv11, cv13) together with certain stylistic sets (ss03, ss07). It also fixes issues with enabling character variants for certain characters (U+0250, U+04D1, U+04D3, U+EE0E).
This pull request is based on Issue #777 by @sorintarmure: For the character
ț(U+021B), enabling cv13 works as expected, resulting in a compactt, and enabling ss03 (or ss07) works as expected, resulting in a round (or square) comma. However, enabling cv13 and ss03 (or cv13 and ss07) together produces an incorrect result, a standardtwith a round (or square) comma, rather than a compacttwith a round (or square) comma.I investigated the bug further and found that it appears with four other character variants (cv05, cv08, cv10, cv11) as well.
This issue has been resolved for the following characters:
ĢLatin capital letter G with cedilla (cv10 + ss03, cv10 + ss07)İLatin capital letter I with dot above (cv08 + ss07)ļLatin small letter l with cedilla (cv05 + ss03, cv05 + ss07)ŀLatin small letter l with middle dot (cv05 + ss07)țLatin small letter t with comma below (cv13 + ss03, cv13 + ss07)ḮLatin capital letter I with diaeresis and acute (cv08 + ss07)ạLatin small letter a with dot below (cv11 + ss07)ậLatin small letter a with circumflex and dot below (cv11 + ss07)ặLatin small letter a with breve and dot below (cv11 + ss07)ỊLatin capital letter I with dot below (cv08 + ss07)While working on this, I discovered that enabling character variants wasn’t working for certain characters.
This issue has been resolved for the following characters:
ɐLatin small letter turned a (cv11)ӑCyrillic small letter a with breve (cv11)ӓCyrillic small letter a with diaeresis (cv11)I tested all my changes manually and ran and passed all the automated tests.