refactor: dont extend Array

Signed-off-by: Kevin Viglucci <[email protected]>
rsocket · Jun 21, 2023 · f4419b0 · f4419b0
1 parent 2f51d02
commit f4419b0
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/packages/rsocket-adapter-rxjs/src/ObserverToBufferingRSocketSubscriber.ts b/packages/rsocket-adapter-rxjs/src/ObserverToBufferingRSocketSubscriber.ts
@@ -23,22 +23,22 @@ import {
 } from "rsocket-core";
 import { Codec } from "rsocket-messaging";
 import { Observer, Subscription } from "rxjs";
-import { applyMixins } from "./Utils";
 
 interface ObserverToBufferingRSocketSubscriber<T>
   extends Subscription,
-    Array<T>,
     Observer<T>,
     Cancellable,
     Requestable,
     OnExtensionSubscriber {}
+
 class ObserverToBufferingRSocketSubscriber<T>
   extends Subscription
   implements Observer<T>, Cancellable, Requestable, OnExtensionSubscriber
 {
   protected wip: number = 0;
   private e: Error;
   private done: boolean;
+  private stack: T[];
 
   constructor(
     protected requested: number,
@@ -48,6 +48,7 @@ class ObserverToBufferingRSocketSubscriber<T>
     protected readonly inputCodec: Codec<T>
   ) {
     super();
+    this.stack = [];
   }
 
   request(n: number) {
@@ -78,7 +79,7 @@ class ObserverToBufferingRSocketSubscriber<T>
   ): void {}
 
   next(value: T) {
-    this.push(value);
+    this.stack.push(value);
 
     this.drain();
   }
@@ -117,7 +118,7 @@ class ObserverToBufferingRSocketSubscriber<T>
       let requested = this.requested;
       let delivered = 0;
       while (delivered < requested) {
-        const next = this.shift();
+        const next = this.stack.shift();
 
         if (next == undefined) {
           if (this.done) {
@@ -136,7 +137,7 @@ class ObserverToBufferingRSocketSubscriber<T>
           break;
         }
 
-        const isTerminated = this.length == 0 && this.done;
+        const isTerminated = this.stack.length == 0 && this.done;
         this.subscriber.onNext(
           {
             data: this.inputCodec.encode(next),
@@ -162,6 +163,4 @@ class ObserverToBufferingRSocketSubscriber<T>
   }
 }
 
-applyMixins(ObserverToBufferingRSocketSubscriber, [Array]);
-
 export default ObserverToBufferingRSocketSubscriber;