Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove hasBufferModule code #196

Closed
wants to merge 1 commit into from
Closed

chore: remove hasBufferModule code #196

wants to merge 1 commit into from

Conversation

sudongyuer
Copy link

remove hasBufferModule code that makes RSocket-js can't work in browser

[One line description of your change]

Motivation:

[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]

Modifications:

[Describe the modifications you've done.]

Result:

[After your change, what will change.]

remove hasBufferModule code that makes RSocket-js can't work in browser
@OlegDokuka
Copy link
Member

hey @sudongyuer !

Any particular errors that prevent it from working in the browser?

@sudongyuer
Copy link
Author

hey @sudongyuer !

Any particular errors that prevent it from working in the browser?

#195

@sudongyuer
Copy link
Author

hey @sudongyuer !
Any particular errors that prevent it from working in the browser?

#195

I think it's necessary to remove it

@viglucci
Copy link
Member

viglucci commented Dec 5, 2021

Hi @sudongyuer , I suspect the issue you are experiencing may be due to tooling or something specific to your environment. To test, I was able to create a working example using create-react-app. Please see my comment on #195 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants