Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autotest.rb #22

Merged
merged 1 commit into from
Feb 13, 2015
Merged

Update autotest.rb #22

merged 1 commit into from
Feb 13, 2015

Conversation

grantneufeld
Copy link
Contributor

Ensure all ActiveSupport files are loaded.

This addresses rspec-autotest issue #21

Running with Ruby 2.2.0, Rails 4.2.0, Rspec-Rails 3.1.0 (rspec-core 3.1.7), produces an `uninitialized constant ActiveSupport::Deprecation` error because the `active_support/deprecation` is not being loaded.

This addresses issue rspec#21
@@ -22,7 +22,7 @@

$:.push(*Dir['vendor/rails/*/lib'])

require 'active_support/core_ext'
require 'active_support/all'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we require active_support/deprecation instead ? core_ext + deprecation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require 'active_support/deprecation'
require 'active_support/core_ext'

Results in: uninitialized constant ActiveSupport::Autoload (NameError).
So, I then tried:

require 'active_support/deprecation'
require 'active_support/autoload'
require 'active_support/core_ext'

Which resulted in: Autotest style autotest/rails_rspec doesn't seem to exist. Aborting.

seuros added a commit that referenced this pull request Feb 13, 2015
@seuros seuros merged commit 4d711d4 into rspec:master Feb 13, 2015
kristjan added a commit to kristjan/pop_the_answer that referenced this pull request May 11, 2015
rspec-autotest v1 doesn't work with Rails 4. The fix was in
rspec/rspec-autotest#22, which is pulled in by
this particular ref.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants