-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Z translate. #104
base: master
Are you sure you want to change the base?
Added Z translate. #104
Conversation
Added the option to set/get z to translation transform. Changed the translation test to include Z property.
Does |
+1 This change actually makes a big difference for mobile webkit since translate3d forces hardware acceleration. Without this change CSS3 is very sluggish on mobile. |
+1 |
1 similar comment
+1 |
|
||
this.translate = this._translateX + "," + this._translateY; | ||
this.translate3d = this._translateX + "," + this._translateY + "," + this._translateZ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you change this line to
if (support.transform3d)
this.translate3d = this._translateX + "," + this._translateY + "," + this._translateZ;
else
this.translate = this._translateX + "," + this._translateY;
your solution also works with browsers that only support 2D transforms!
+1000... is this plugin dead? |
+1 for the hardware acceleration |
It looks like dynamically utilizing |
+1 |
I'm not very familiar with Git yet. What do I need to do to have this translateZ function in my basic transit.js file (minify) ? EDIT: The doc I use to code is the main page of http://ricostacruz.com/jquery.transit/ ; maybe I can find somewhere something more up to date, or more complete ? EDIT II : Just pick up the file non-minify and edit it line by line. The power of github is too strong for me ;) But it works 👍 |
Added the option to set/get Z to translation transform.
Changed the translation test to include Z property.