Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ShinyResizeObserver #566

Merged
merged 17 commits into from
May 9, 2023
Merged

Add ShinyResizeObserver #566

merged 17 commits into from
May 9, 2023

Commits on May 5, 2023

  1. Add ShinyResizeObserver class and fix sidebar resizing during trans… 

    …ition
    @gadenbuie
    gadenbuie committed May 5, 2023
    Configuration menu
    Copy the full SHA
    66a3a8a View commit details
    Browse the repository at this point in the history

  2. Mark updated elements with their RO owners 

    To avoid contention between outputs within both cards and sidebars
    @gadenbuie
    gadenbuie committed May 5, 2023
    Configuration menu
    Copy the full SHA
    41712c6 View commit details
    Browse the repository at this point in the history

  3. yarn build (GitHub Actions)

    @gadenbuie
    gadenbuie committed May 5, 2023
    Configuration menu
    Copy the full SHA
    2230045 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Bail early when handling resize if not in Shiny

    @gadenbuie
    gadenbuie committed May 8, 2023
    Configuration menu
    Copy the full SHA
    2654175 View commit details
    Browse the repository at this point in the history

  2. Mark owner a little earlier

    @gadenbuie
    gadenbuie committed May 8, 2023
    Configuration menu
    Copy the full SHA
    5c84d40 View commit details
    Browse the repository at this point in the history

  3. Use type parameters to simplify .querySelectorAll().forEach() calls

    @gadenbuie
    gadenbuie committed May 8, 2023
    Configuration menu
    Copy the full SHA
    7bbc95b View commit details
    Browse the repository at this point in the history

  4. Add unobserve() method

    @gadenbuie
    gadenbuie committed May 8, 2023
    Configuration menu
    Copy the full SHA
    48ff82f View commit details
    Browse the repository at this point in the history

  5. yarn build

    @gadenbuie
    gadenbuie committed May 8, 2023
    Configuration menu
    Copy the full SHA
    8f56efa View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Carson Sievert <[email protected]>
    @gadenbuie @cpsievert
    gadenbuie and cpsievert authored May 9, 2023
    Configuration menu
    Copy the full SHA
    778da4e View commit details
    Browse the repository at this point in the history

  2. yarn build (GitHub Actions)

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    e050182 View commit details
    Browse the repository at this point in the history

  3. Resave data (GitHub Action)

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    57f4c9d View commit details
    Browse the repository at this point in the history

  4. Early exit if no plots need adjustment during resize

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    3f07fed View commit details
    Browse the repository at this point in the history

  5. yarn build

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    525babc View commit details
    Browse the repository at this point in the history

  6. mark owner only once

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    b239505 View commit details
    Browse the repository at this point in the history

  7. Handle plot image width within .shiny-bound-output visitor

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    cbe9cd8 View commit details
    Browse the repository at this point in the history

  8. yarn build

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    66e4057 View commit details
    Browse the repository at this point in the history

  9. fix typo in selector

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    9be14c6 View commit details
    Browse the repository at this point in the history