Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rendering rss on render_site() #189

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

javierluraschi
Copy link
Contributor

Running rmarkdown::render_site() under the https://github.com/rstudio/ai-blog repo does not generate the RSS feed.

This fix searches for the active post being rendered and matches the article$path with the existing local path to the Rmd being generated.

Fix seems to work fine even when using rmarkdown::render_site(input_path = "../ai-blog"), likely due to rmarkdown setting a consistent path while building the site.

javierluraschi added a commit to rstudio/ai-blog that referenced this pull request Oct 6, 2020
@jjallaire jjallaire merged commit 8b5520a into rstudio:master Oct 6, 2020
@jjallaire
Copy link
Member

@javierluraschi I had to revert this as running render_site() on the AI blog with this change applies results in an error (it attempts to render a post which gives an error for data.table not installed and another png related. here). Revert here :6e3da92

We can merge a version of this that doesn't force re-renders of earlier posts but I am just about to wrap up a release for CRAN and would like to see any change we make tested more broadly before it goes into a CRAN release.

@javierluraschi
Copy link
Contributor Author

Ah yes, there are chunks that do run and require data.table, tracking with rstudio/ai-blog#117.

Sent another PR to opt-in to fully rebuild the RSS with #190 -- Probably worth skipping for CRAN release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants