Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to set subdir on the PVC volume mount #404

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Conversation

colearendt
Copy link
Contributor

One thing that needs to be vetted: Does Launcher / the job launching process handle this subdir properly (and subdir below it?)... or will we need to pass this sub-directory along somehow?

Also need to:

  • bump chart versions
  • add NEWS entries

Copy link
Contributor

@jforest jforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, and it would be great to get it out.

I'm happy to help test it in whatever way I can before I use it in my PR here: https://github.com/rstudio/aws-main-services/pull/625

@colearendt
Copy link
Contributor Author

Tested a bit and things look good!

@colearendt colearendt merged commit f95d05b into main Aug 11, 2023
4 checks passed
@colearendt colearendt deleted the add-subdir branch August 11, 2023 14:44
@dbkegley
Copy link
Collaborator

dbkegley commented Oct 5, 2023

One thing that needs to be vetted: Does Launcher / the job launching process handle this subdir properly (and subdir below it?)... or will we need to pass this sub-directory along somehow?

When off-host is enabled for Connect, I don't think this setting will play nicely with Launcher.DataDirPVCName, which will not allow setting a subpath currently. Using this new setting with off-host enabled will likely cause the content datadir to be misaligned

"volumes": [
    {
      "name": "mount0",
      "persistentVolumeClaim": {
        "claimName": "connect-pvc"
      }
    },
...
],
"volumeMounts": [
    {
      "mountPath": "/opt/rstudio-connect/mnt/app",
      "name": "mount0",
      "subPath": "apps/1/1"
    },
...
  ]

In the above example, I think apps/1/1 should really be: <sharedStorage.subPath>/apps/1/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants