Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licensing section to READMEs #432

Merged
merged 32 commits into from
Nov 27, 2023
Merged

Add licensing section to READMEs #432

merged 32 commits into from
Nov 27, 2023

Conversation

tnederlof
Copy link
Contributor

This PR adds a "Licensing" section to the Workbench, Connect, and Package Manager READMEs, showing consumers of the charts different ways to use license files, keys, and servers with our helm charts. This is one point that customers struggle with, especially license files (which is soon to be our default).

Closes #426

@tnederlof tnederlof added documentation Improvements or additions to documentation rsc rsw rspm labels Oct 25, 2023
@tnederlof tnederlof self-assigned this Oct 25, 2023
Copy link
Collaborator

@atheriel atheriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice addition!

@tnederlof
Copy link
Contributor Author

tnederlof commented Nov 8, 2023

@atheriel sorry to bug you again but needed to bump the versions

Copy link
Contributor

@colearendt colearendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One note - I think putting this into the shared .gotmpl file might have been easier than copying / pasting in 3 places, but it's all good 😄

Copy link
Contributor

@colearendt colearendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Well done!

@colearendt colearendt merged commit 497effc into main Nov 27, 2023
1 check passed
@colearendt colearendt deleted the tn-add-licensing-docs branch November 27, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rsc rspm rsw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation/examples on how to create/consume secrets for license files
5 participants