-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add licensing section to READMEs #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a nice addition!
@atheriel sorry to bug you again but needed to bump the versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One note - I think putting this into the shared .gotmpl
file might have been easier than copying / pasting in 3 places, but it's all good 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 Well done!
This PR adds a "Licensing" section to the Workbench, Connect, and Package Manager READMEs, showing consumers of the charts different ways to use license files, keys, and servers with our helm charts. This is one point that customers struggle with, especially license files (which is soon to be our default).
Closes #426