Pin charts to specific rstudio library versions #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low us to pin the version
…nstall test, I don't think it gains us anything
jforest
requested review from
aronatkins,
dbkegley,
christierney,
zackverham and
a team
as code owners
dbkegley
approved these changes
Nov 1, 2024
…hub.com:rstudio/helm into pin-charts-to-specific-rstudio-library-versions
…hub.com:rstudio/helm into pin-charts-to-specific-rstudio-library-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to modify the
rstudio-librarychart independently of updating all the charts.Each team can then decide when to move to new library versions, as they see fit.
closes #601
EDIT: I also removed the unneeded
charts/rstudio-workbench/templates/tests/test-verify-installation.yamltemplate file that is only used byhelm testourct installtests already do a test installation, this feels like a duplicate