feat: option to initialize storage servers without chunker #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal with this change is to allow storage servers to be initialized without needing a database to be running first. By allowing the storage server to start without the chunker, it can still use Put() without chunking. When WriteChunked() or ReadChunked() are needed by the storage server, it first checks that the chunker is not nil. If it is, it will throw an error.
jmwoliver
force-pushed
the
jmw/storage-without-chunker
branch
from
2c99fbe
to
847959e
Compare
|
What does the Chunker use the database for? Is there an opportunity to decouple the two entirely? |
|
We went a different route in PPM that didn't require platform-lib changes. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal with this change is to allow storage servers to be initialized without needing a database to be running first.
By allowing the storage server to start without the chunker, it can still use
Put()without chunking. WhenWriteChunked()orReadChunked()are needed by the storage server, it first checks that the chunker is not nil. If it is, it will throw an error.Initial work needed for https://github.com/rstudio/package-manager/issues/13651.