Add R builds for RHEL 9 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS 7 is the last distro affected by this bug, so invert the logic to make maintenance easier.
glin
commented
Aug 18, 2022
Comment on lines
+11
to
+27
| # Create post-install script required for OpenBLAS. | ||
| # | ||
| # On RHEL and SUSE, we link R against the internal shared BLAS to make the | ||
| # R binaries more portable and allow users to switch BLAS implementations without | ||
| # having to recompile R. We default to OpenBLAS, but users may prefer other implementations. | ||
| # | ||
| # Binary packages built against the shared BLAS are also more portable and may be used | ||
| # with the default R distributed by RHEL/SUSE, or other R installations using | ||
| # shared BLAS and configured with a different BLAS (such as Microsoft R Open with MKL). | ||
| # This is especially important for RSPM's binary packages. | ||
| # | ||
| # On Ubuntu/Debian, we link R against the external BLAS instead (--with-blas/--with-lapack), | ||
| # as those distributions use the alternatives system to swap BLAS libraries at runtime. | ||
| # The default R distributions on Ubuntu/Debian use the external BLAS, so we do as well | ||
| # for portability. | ||
| # | ||
| # https://cran.r-project.org/doc/manuals/r-release/R-admin.html#Shared-BLAS |
There was a problem hiding this comment.
@michaelmayer2 I've added some docs to explain how we configure BLAS here (#132)
I'll add a similar comment to the openSUSE 15.4 build as well. I didn't copy these over to the previous CentOS versions since we usually just add new platforms based off the most recent version of that distro.
jonyoder
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add R builds for RHEL 9, based on Rocky Linux 9. This was mostly copied over from the centos-8 (Rocky 8) build, with a few differences to note:
JAVA_HOMEis explicitly set to a major-versioned path to make Java configuration easier on users, based on @michaelmayer2's work in update builder (Docker and package files for better java support) #113.RStudio, PBC <https://github.com/rstudio/r-builds>GPL-2license field to the RPM standardGPLv2+I've run a test workflow with the full matrix of R versions at https://github.com/rstudio/r-builds/actions/runs/2878921915