guard against unexpected user agent values (closes #1787)

rstudio · Jan 9, 2024 · bdb8aa5 · bdb8aa5
1 parent de3af61
commit bdb8aa5
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/R/http.R b/R/http.R
@@ -1,7 +1,13 @@
 
 renv_http_useragent <- function() {
+
+  # https://github.com/rstudio/renv/issues/1787
   agent <- getOption("renv.http.useragent", default = getOption("HTTPUserAgent"))
-  agent %||% renv_http_useragent_default()
+  if (is.character(agent) && length(agent) == 1L)
+    return(agent)
+
+  renv_http_useragent_default()
+
 }
 
 renv_http_useragent_default <- function() {

diff --git a/tests/testthat/test-http.R b/tests/testthat/test-http.R
@@ -0,0 +1,13 @@
+
+test_that("renv handles unexpected user agent values", {
+
+  # https://github.com/rstudio/renv/issues/1787
+  renv_scope_options(HTTPUserAgent = character())
+  agent <- renv_http_useragent()
+  expect_equal(agent, renv_http_useragent_default())
+
+  renv_scope_options(HTTPUserAgent = NULL)
+  agent <- renv_http_useragent()
+  expect_equal(agent, renv_http_useragent_default())
+
+})