Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject CSS styling into RMD parametrization app #866

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Inject CSS styling into RMD parametrization app #866

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2858c1f
added script/style string support
Nov 10, 2016
90b0ada
Revert "added script/style string support"
Nov 11, 2016
b0961f4
[params] added support for custom CSS/scripts
Nov 11, 2016
78958a6
Merge branch 'uriel/knit_with_params'
Nov 11, 2016
99e714d
[params] added tests to params_html_head
Nov 11, 2016
202f3e9
[params] typo in docs
Nov 11, 2016
c1ab123
[params] removed bootstrap
Nov 16, 2016
cfec064
[params] added support for disabling bootstrap
Nov 16, 2016
7f4acd0
[doc] updated docs
Nov 16, 2016
b8bb6f0
Merge branch 'master' of https://github.com/rstudio/rmarkdown
Nov 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions R/params.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ params_html_head <- function(html_head_style = c(),
#' You must take care to unsure that the URL is absolute.
#' @param html_head_script_link same as above except that these are interpreted as SRC attributes in SCRIPT tags.
#' You must take care to unsure that the URL is absolute.
#' @param disable_bootstrap if true, does not inject boostrap scripts and styles in the HTML HEAD.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the common formatting is for this package, but you could consider styling with if \code{TRUE}, does not... Probably more important to align with the conventions of the package but just making sure you're aware of the option.

#'
#' @return named list with overridden parameter names and value.
#'
Expand All @@ -263,7 +264,8 @@ knit_params_ask <- function(file = NULL,
html_head_style = c(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One option that won't pollute the argument list so much is to have a single argument that accepts a named list.

html_head = list()

Then, if you want to specify some parts:

html_head = list(style = "body { font-size: 15px; }")

Not sure which would be preferred.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, when I replied in the email, it put the comments in the wrong place.
I initially had the same idea, but as per @trestletech , the long form is preferred.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could indeed go either way. I agree with @trestletech that R tends to stylistically prefer long argument lists. Even though this isn't normally good form in more well decomposed systems in R where many operations tend to be top level "one button" ones it makes some sense (also forces documentation of the parameters in .Rd as a side benefit).

html_head_script = c(),
html_head_style_link = c(),
html_head_script_link = c()) {
html_head_script_link = c(),
disable_bootstrap = FALSE) {

if (is.null(input_lines)) {
if (is.null(file)) {
Expand Down Expand Up @@ -462,7 +464,9 @@ knit_params_ask <- function(file = NULL,
class = "container-fluid"),
class = "navbar navbar-default navbar-fixed-bottom")

ui <- shiny::tagList(
buildPage <- ifelse((is.null(disable_bootstrap) | !isTruthy(disable_bootstrap)), shiny::bootstrapPage, shiny::tagList)

ui <- buildPage(
params_html_head(
html_head_style = html_head_style,
html_head_script = html_head_script,
Expand Down