Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Posit logo/link to docs footer #367

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Add Posit logo/link to docs footer #367

merged 5 commits into from
Oct 20, 2023

Conversation

mmarchetti
Copy link
Contributor

@mmarchetti mmarchetti commented Oct 4, 2023

This PR adds a Posit logo/link to the docs footer, similar to https://github.com/rstudio/connect/pull/24572.

Fixes #366

Directions for Reviewers

Build the docs and view them.

cd docs/site
just ../ build && python -m http.server

wydsith
wydsith previously approved these changes Oct 16, 2023
@wydsith wydsith dismissed their stale review October 19, 2023 19:44

logo only on index, need to update for addition to other pages, we should remove logo from header

@mmarchetti mmarchetti merged commit 59f0935 into master Oct 20, 2023
10 checks passed
@mmarchetti mmarchetti deleted the mm-docs-footer-logo branch October 20, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posit logo in rsconnect-jupyter docs
3 participants