Sys.setlocale returns the updated locale, not the previous one #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronatkins
force-pushed
the
aron-properly-restore-locale
branch
from
7a6943f
to
a383a2f
Compare
aronatkins
changed the title
aronatkins
referenced
this pull request
Jan 17, 2024
* Restyle and reorder functions * Eliminate `httpInvokeRequest()` * Extract out repeated code and test new `authHeaders()` function * Standardise structure of `httpRequest()` and `httpRequestWithBody()`
hadley
reviewed
Jan 17, 2024
| @@ -518,10 +518,11 @@ signatureHeaders <- function(authInfo, method, path, file = NULL) { | |||
|
|
|||
| rfc2616Date <- function(time = Sys.time()) { | |||
| # set locale to POSIX/C to ensure ASCII date | |||
| old <- Sys.setlocale("LC_TIME", "C") | |||
| old <- Sys.getlocale("LC_TIME") | |||
There was a problem hiding this comment.
Of course Sys.setlocale() works differently 😭
hadley
approved these changes
Jan 17, 2024
|
Note: The CI failures are unrelated to this change; there's an active Posit Package Manager problem. Will re-run CI once that clears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by 972dc8d#r137282282.
@Upipa, would you be able to test this change? It closely resembles your suggestion.