Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 312-bslib-sidebar-resize #166

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Add 312-bslib-sidebar-resize #166

wants to merge 29 commits into from
+530 −2

Commits on May 9, 2023

  1. Add 312-bslib-sidebar-resize (manual app)

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    dca0e3c View commit details
    Browse the repository at this point in the history

  2. Use page_navbar() for shared sidebar

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    eac7185 View commit details
    Browse the repository at this point in the history

  3. Programmatically test sidebar transition

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    daf5438 View commit details
    Browse the repository at this point in the history

  4. Generate apps deps (GitHub Actions)

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    db7723f View commit details
    Browse the repository at this point in the history

  5. Update tests to use diff() and to include labels on all expectations

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    ff5c45b View commit details
    Browse the repository at this point in the history

  6. Merge 'origin/main' into '312-bslib-sidebar-resize'

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    620c85c View commit details
    Browse the repository at this point in the history

  7. Generate apps deps (GitHub Actions)

    @gadenbuie
    gadenbuie committed May 9, 2023
    Configuration menu
    Copy the full SHA
    3673e29 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Refactor test code to avoid duplication

    @gadenbuie
    gadenbuie committed May 10, 2023
    Configuration menu
    Copy the full SHA
    844bf7f View commit details
    Browse the repository at this point in the history

  2. Another small refactor for better failure backtraces

    @gadenbuie
    gadenbuie committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6164d43 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Add client-size htmlwidget resizing test

    @gadenbuie
    gadenbuie committed May 15, 2023
    Configuration menu
    Copy the full SHA
    9eaee9a View commit details
    Browse the repository at this point in the history

  2. Remove call to browser()

    @gadenbuie
    gadenbuie authored May 15, 2023
    Configuration menu
    Copy the full SHA
    0f8ef3c View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Merged origin/main into 312-bslib-sidebar-resize

    @gadenbuie
    gadenbuie committed May 18, 2023
    Configuration menu
    Copy the full SHA
    247df09 View commit details
    Browse the repository at this point in the history

  2. add debugging for windows and limit to just windows

    @gadenbuie
    gadenbuie committed May 18, 2023
    Configuration menu
    Copy the full SHA
    50767b2 View commit details
    Browse the repository at this point in the history

  3. debug: try again

    @gadenbuie
    gadenbuie committed May 18, 2023
    Configuration menu
    Copy the full SHA
    2e443c3 View commit details
    Browse the repository at this point in the history

  4. debug: more output printing

    @gadenbuie
    gadenbuie committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b78e103 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Revert debugging changes 

    This reverts commit b78e103.

Revert "debug: try again"

This reverts commit 2e443c3.

Revert "add debugging for windows and limit to just windows"

This reverts commit 50767b2.
    @gadenbuie
    gadenbuie committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e7ad0ed View commit details
    Browse the repository at this point in the history

  2. Use nav_panel()

    @gadenbuie
    gadenbuie committed May 19, 2023
    Configuration menu
    Copy the full SHA
    6e42aea View commit details
    Browse the repository at this point in the history

  3. Rename test file

    @gadenbuie
    gadenbuie committed May 19, 2023
    Configuration menu
    Copy the full SHA
    93831c8 View commit details
    Browse the repository at this point in the history

  4. Skip transition animation tests on windows

    @gadenbuie
    gadenbuie committed May 19, 2023
    Configuration menu
    Copy the full SHA
    d0f224d View commit details
    Browse the repository at this point in the history

  5. Split out helper code, split tests into blocks

    @gadenbuie
    gadenbuie committed May 19, 2023
    Configuration menu
    Copy the full SHA
    eb49d67 View commit details
    Browse the repository at this point in the history

  6. Add README for 312

    @gadenbuie
    gadenbuie committed May 19, 2023
    Configuration menu
    Copy the full SHA
    09ecf09 View commit details
    Browse the repository at this point in the history

  7. skip on windows without help from {shinycoreci}

    @gadenbuie
    gadenbuie committed May 19, 2023
    Configuration menu
    Copy the full SHA
    38fa35c View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. Merge 'origin/main' into '312-bslib-sidebar-resize'

    @gadenbuie
    gadenbuie committed May 20, 2023
    Configuration menu
    Copy the full SHA
    509aca1 View commit details
    Browse the repository at this point in the history

  2. Generate apps deps (GitHub Actions)

    @gadenbuie
    gadenbuie committed May 20, 2023
    Configuration menu
    Copy the full SHA
    610e93c View commit details
    Browse the repository at this point in the history

  3. test again after routine file changes

    @gadenbuie
    gadenbuie committed May 20, 2023
    Configuration menu
    Copy the full SHA
    c11a494 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. bring back some debugging output

    @gadenbuie
    gadenbuie committed May 22, 2023
    Configuration menu
    Copy the full SHA
    52612da View commit details
    Browse the repository at this point in the history

  2. slow down transition to see if that helps

    @gadenbuie
    gadenbuie committed May 22, 2023
    Configuration menu
    Copy the full SHA
    bee1c57 View commit details
    Browse the repository at this point in the history

  3. Hide debug messages behind envvar

    @gadenbuie
    gadenbuie committed May 22, 2023
    Configuration menu
    Copy the full SHA
    452178b View commit details
    Browse the repository at this point in the history

  4. Add a $wait_for_js() to keep test in sync with browser

    @gadenbuie
    gadenbuie committed May 22, 2023
    Configuration menu
    Copy the full SHA
    8671d17 View commit details
    Browse the repository at this point in the history