-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added list of tlmgr packages to install as data #233
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I am not sure if/how tests should be made for this contribution. Suggestions/direction welcome.
Don't worry about it. I don't care in this case.
Thanks!
"upquote" | ||
) | ||
|
||
usethis::use_data(jup_pkgs, overwrite = TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to introduce the dependency on usethis only for the purpose of saving a simple vector to .rda
and documenting it. I prefer not exporting or documenting jup_pkgs
here. That means users will need to use :::
, which I think is fine. This is not a super important object anyway.
That said, it will be good to briefly mention it on the TinyTeX documentation site, e.g. after FAQ 12: https://yihui.org/tinytex/faq/
An alternative approach is like this: https://github.com/yihui/tinytex/blob/b84fd550ffb72a8f20d323144fe269f4a5173c9a/R/install.R#L342-L346 i.e. save the list of packages under tools/pkgs-jupyter.txt
, so both the R function and the shell script can read it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was curious as to whether adding usethis::use_data_raw()
would mean that it needed to be added as a dev dependency. So I queried Allison Hill on this. She said that "The scripts in data_raw/ are for you. They are your way of creating the package but that directory is added to your .Rbuildignore
when you set it up with usethis
" (see Twitter conversation here). So in general it seems that technically this does not make usethis
a dev dependency. However, I am happy to defer to your preferred way to do this. Another advantage of doing something like install_yihui_pkgs
with a the list of packages in tools/pkgs-jupyter.txt
is that, as you mentioned, the shell script can read it.
Once you confirm this is for sure the way you want to go, I will change to PR to reflect it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please store the list of packages in tools/pkgs-jupyter.txt
, and remove the dependency on usethis. Thank you!
|
450bcac
to
afb10f3
Compare
Based on the conversation in #228 I am submitting this pull request to add a data object named
jup_pkgs
so that the additional packages required for using {tinytex} with Jupyter can be installed via:A couple of notes:
tools/install-unx.sh
script would work for example?