Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add formatter #13

Merged
merged 20 commits into from
Jan 15, 2024
Merged

feat: add formatter #13

merged 20 commits into from
Jan 15, 2024

Conversation

rszyma
Copy link
Owner

@rszyma rszyma commented Jan 8, 2024

Depends on

Changes:

  • add support for formatting
  • add a simple formatting "rule" remove_excessive_adjacent_newlines as a PoC that this formatting thing works

Also:

  • update cargo dependencies
  • declare capabilities in limited workspaces in package.json
  • update publish workflow to build with --release flag

TODO:

@rszyma rszyma mentioned this pull request Jan 8, 2024
4 tasks
jtroo pushed a commit to jtroo/kanata that referenced this pull request Jan 13, 2024
- add `span()` to `SExprMetaData`
- add `pub` to some methods
- remove `PartialOrd` and `Ord` for types, where comparison doesn't make
sense
- move unterminated block comment error catching from `parse` to
`parse_`

I need this merged, especially the last thing from the bullet list above
to get rszyma/vscode-kanata#13 working
correctly.
@rszyma rszyma marked this pull request as ready for review January 14, 2024 22:41
@rszyma
Copy link
Owner Author

rszyma commented Jan 15, 2024

Formatting deflayers doesn't work yet in included files. Support for it will be added in a separate PR. Formatter is disabled-by-default in settings right now.

@rszyma rszyma merged commit 20b6142 into main Jan 15, 2024
1 check passed
@rszyma rszyma deleted the formatter branch January 15, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant