-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pimple container version #162
Conversation
Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/162/merge/ |
Hi @NikhilJoshua, Verified the PR but while activating the plugin there's fatal error is visible. Please check: |
@pavanpatil1 Can you please try deleting the |
Hi @NikhilJoshua, after executing the above steps able to activate the plugin successfully. However, user should not perform this extra step to activate the plugin. Could you please check and update the require dependencies. |
@pavanpatil1 I believe the issue was specific to your system, was not able to replicate in local. Can you please check in any other system to confirm it's not an issue from your side. |
@NikhilJoshua that shouldn't be the case as the GH action is also failing on same issue Still, I will cross-checking this once again on rt.gw site |
Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/162/merge/ |
Hi @NikhilJoshua, verified the fix and it is working fine now. Able to activate the plugin successfully and it is working fine. However, there are still some deprecated notices after adding the login with google block - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 12 errors
Powered by rtCamp's GitHub Actions Library
Posting will continue in further review(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous scan continued.
Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/162/merge/ |
Verified the fix and it is working fine now. The deprecated notices are not visible now. @NikhilJoshua you can merge the PR to master. Just the check the inspection check why it it failing. |
Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/162/merge/ |
@pavanpatil1 Fixed the phpcs scan on |
Hi @NikhilJoshua, It is working fine now. Please get the PR reviewed and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
vendor folder was not ignored while checking.
Summary
3.5.*
in composer.json for PHP 8.1 Compatibilitycloses #161