Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pimple container version #162

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

NikhilJoshua
Copy link
Contributor

Summary

  • Update Pimple version to 3.5.* in composer.json for PHP 8.1 Compatibility

closes #161

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

@pavanpatil1
Copy link
Contributor

Hi @NikhilJoshua, Verified the PR but while activating the plugin there's fatal error is visible. Please check:

image

@NikhilJoshua
Copy link
Contributor Author

@pavanpatil1 Can you please try deleting the vendor folder and do a composer install ?

@pavanpatil1
Copy link
Contributor

Hi @NikhilJoshua, after executing the above steps able to activate the plugin successfully. However, user should not perform this extra step to activate the plugin. Could you please check and update the require dependencies.

@NikhilJoshua
Copy link
Contributor Author

@pavanpatil1 I believe the issue was specific to your system, was not able to replicate in local. Can you please check in any other system to confirm it's not an issue from your side.

@pavanpatil1
Copy link
Contributor

pavanpatil1 commented Sep 4, 2023

@NikhilJoshua that shouldn't be the case as the GH action is also failing on same issue

image

Still, I will cross-checking this once again on rt.gw site

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

@pavanpatil1
Copy link
Contributor

Hi @NikhilJoshua, verified the fix and it is working fine now. Able to activate the plugin successfully and it is working fine. However, there are still some deprecated notices after adding the login with google block -

image

Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 12 errors

⚠️ 4 warnings


Powered by rtCamp's GitHub Actions Library

Posting will continue in further review(s)

vendor/composer/InstalledVersions.php Show resolved Hide resolved
vendor/composer/InstalledVersions.php Show resolved Hide resolved
vendor/composer/InstalledVersions.php Show resolved Hide resolved
vendor/composer/platform_check.php Show resolved Hide resolved
vendor/composer/platform_check.php Show resolved Hide resolved
vendor/composer/platform_check.php Show resolved Hide resolved
vendor/composer/platform_check.php Show resolved Hide resolved
vendor/pimple/pimple/src/Pimple/Container.php Show resolved Hide resolved
vendor/pimple/pimple/src/Pimple/Container.php Show resolved Hide resolved
vendor/pimple/pimple/src/Pimple/Container.php Show resolved Hide resolved
rtBot
rtBot previously requested changes Sep 4, 2023
Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous scan continued.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

@pavanpatil1
Copy link
Contributor

Verified the fix and it is working fine now. The deprecated notices are not visible now. @NikhilJoshua you can merge the PR to master.

Just the check the inspection check why it it failing.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

@NikhilJoshua
Copy link
Contributor Author

@pavanpatil1 Fixed the phpcs scan on vendor folder. Please check.

@pavanpatil1
Copy link
Contributor

Hi @NikhilJoshua, It is working fine now. Please get the PR reviewed and merged.

Copy link

@vishalkakadiya vishalkakadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NikhilJoshua NikhilJoshua dismissed rtBot’s stale review September 5, 2023 10:36

vendor folder was not ignored while checking.

@NikhilJoshua NikhilJoshua merged commit f60358a into master Sep 5, 2023
7 of 8 checks passed
@NikhilJoshua NikhilJoshua deleted the update/pimple-container-version branch September 5, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP Deprecated notices visible with PHP8.1.
4 participants