Migration of One tap to FedCM #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/182/merge/ |
|
@mchirag2002 Have you followed all the applicable migration steps? |
SH4LIN
requested changes
Jul 24, 2024
|
Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/182/merge/ |
SH4LIN
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will migrate the one-tap login functionality to FedCM.
Technical Implementation
Added
data-use_fedcm_for_prompt="true"attribute to the one-tap prompt markup.Fixes/Covers
#179