Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add tests for CoreParagraph block #26

Merged
merged 7 commits into from
Sep 26, 2024
Merged

tests: Add tests for CoreParagraph block #26

merged 7 commits into from
Sep 26, 2024

Conversation

ashutoshgautams
Copy link
Collaborator

@ashutoshgautams ashutoshgautams commented Sep 24, 2024 •
edited by justlevine
Loading

Tracking wpengine#300

What

This PR adds comprehensive tests for the CoreParagraph block and its attributes.

Tested attributes:

  • align
  • anchor
  • backgroundColor
  • className
  • content
  • cssClassName
  • dropCap
  • direction
  • fontFamily
  • fontSize
  • gradient
  • lock
  • placeholder
  • style
  • textColor

Untested fields:

  • CoreParagraphAttributes.metadata - @todo

Exposed issues:

  • None identified during testing. All attributes appear to be correctly implemented and returned as expected.

@ashutoshgautams ashutoshgautams self-assigned this Sep 24, 2024
justlevine
justlevine requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs the inline comments added and tests passing on old versions.

@ashutoshgautams ashutoshgautams marked this pull request as ready for review September 24, 2024 18:46
justlevine
justlevine approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the Additional Notes since it didn't add value. Go ahead and open this up on WPE 🙌

@ashutoshgautams ashutoshgautams added the has-upstream-pr A PR has been opened against wpengine's repo label Sep 24, 2024
@justlevine justlevine merged commit cf3c199 into main Sep 26, 2024
10 checks passed
@justlevine justlevine deleted the core-paragraph-test branch October 18, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justlevine justlevine justlevine approved these changes

Assignees

@ashutoshgautams ashutoshgautams

Labels
has-upstream-pr A PR has been opened against wpengine's repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashutoshgautams @justlevine