Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : backporting populate_template_part_inner_blocks #32

Closed
wants to merge 2 commits into from

Conversation

Ta5r
Copy link
Collaborator

@Ta5r Ta5r commented Dec 12, 2024

What you did in this PR ?

Back ported functionality to resolve and populate innerBlocks for core/template-part blocks and included a test to ensure template part inner blocks are resolved correctly.

Why is it necessary ?

This is necessary so as to support nested blocks within template-part blocks.

How ?

  • Backported populate_template_part_inner_blocks to retrieve and parse template part content using get_block_templates.
  • Added a integration test to validate the correct resolution of template part blocks in both flat and nested contexts.

Tasks :

  • Backport populate_template_part_inner_blocks()
  • Add Codeception unit test

@Ta5r Ta5r self-assigned this Dec 12, 2024
@Ta5r Ta5r changed the title Feat/backporting cb resolver func Feat : backporting populate_template_part_inner_blocks Dec 17, 2024
@Ta5r Ta5r requested a review from justlevine December 17, 2024 10:59
@Ta5r Ta5r marked this pull request as ready for review December 17, 2024 13:24
@justlevine justlevine force-pushed the feat/backporting_cb_resolver_func branch 3 times, most recently from aede68c to c46e021 Compare December 17, 2024 18:10
Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking: wpengine#324

@justlevine justlevine force-pushed the feat/backporting_cb_resolver_func branch from c46e021 to ffb6c83 Compare December 18, 2024 21:18
@justlevine
Copy link
Collaborator

Merged upstream 🚀

@justlevine justlevine closed this Dec 19, 2024
@justlevine justlevine deleted the feat/backporting_cb_resolver_func branch December 20, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants