Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor(formatting): replace eslint and prettier with biome #326

Merged
merged 11 commits into from
Dec 21, 2023

Conversation

larwaa
Copy link
Member

@larwaa larwaa commented Dec 20, 2023

Changes

  • Biome is a formatter and linter for JavaScript that is quite a lot faster than the current eslint/prettier combo. Replace ESLint and Prettier with Biome, resulting in some relaxed rules, but increased performance.
  • Change import alias to be ~/ instead of @/ so that organize imports behaves nicely.
  • Remove prettier
  • Remove eslint
  • Use a rule set for formatting with Biome that is closer to our previous rule set to limit the scope of the PR
  • Fix lint issues
  • Format files

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (130ea66) 94.71% compared to head (63b25df) 94.79%.

Files Patch % Lines
src/lib/fastify/health-checks.ts 0.00% 3 Missing ⚠️
src/lib/prisma.ts 25.00% 3 Missing ⚠️
src/graphql/cabins/schema.mappers.ts 0.00% 2 Missing ⚠️
src/graphql/events/schema.mappers.ts 0.00% 0 Missing and 1 partial ⚠️
src/graphql/users/schema.mappers.ts 0.00% 0 Missing and 1 partial ⚠️
src/repositories/events/repository.ts 97.67% 1 Missing ⚠️
src/services/events/service.ts 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   94.71%   94.79%   +0.07%     
==========================================
  Files         118      118              
  Lines        5964     6066     +102     
  Branches      570      575       +5     
==========================================
+ Hits         5649     5750     +101     
- Misses        302      303       +1     
  Partials       13       13              
Flag Coverage Δ
integrationtests 78.51% <76.21%> (-0.36%) ⬇️
node 94.79% <97.35%> (+0.07%) ⬆️
unittests 48.99% <66.74%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.3% Duplication on New Code

See analysis details on SonarCloud

@larwaa larwaa changed the title Chore/biome ♻️ refactor(formatting): replace eslint and prettier with biome Dec 21, 2023
@larwaa larwaa merged commit 7e35534 into main Dec 21, 2023
17 checks passed
@larwaa larwaa deleted the chore/biome branch December 21, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant