Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes default sourceType of js extraction from 'script' to 'module'… #145

Merged
merged 3 commits into from
Jun 14, 2016
Merged

Changes default sourceType of js extraction from 'script' to 'module'… #145

merged 3 commits into from
Jun 14, 2016

Conversation

IShotTheSheriff
Copy link
Collaborator

…. It fixes issue #144 with parsing ES6 code.

@rubenv
Copy link
Owner

rubenv commented Jun 3, 2016

Could you add a unit test that demonstrates why this is needed? Just to make sure we don't break it again in the future.

@sbrandtb
Copy link

sbrandtb commented Jun 7, 2016

I tried locally. It may fix the issues you mentioned regarding imports, but it doesn't solve the issues with using double colons

@IShotTheSheriff
Copy link
Collaborator Author

@rubenv sure I've just added test cases for both export and import features of ES6.
@sbrandtb yea I was targeting only import/export problem as it stopped whole files from being parsed. I can try to fix double colons issue in another PR if you can provide me with some example of what's wrong.

@rubenv rubenv merged commit 0bf1004 into rubenv:master Jun 14, 2016
@rubenv
Copy link
Owner

rubenv commented Jun 14, 2016

Excellent patch! Merged.

@rubenv
Copy link
Owner

rubenv commented Jun 14, 2016

Release v2.2.2 of angular-gettext-tools and grunt-angular-gettext.

Thanks a lot @IShotTheSheriff!

@IShotTheSheriff IShotTheSheriff deleted the ES6-parsing branch June 16, 2016 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants