Fix ts extract support

[IvanoAlvino]

Since version 2.3.7 ts extract support is broken, reason beeing the ecmaFeatures jsx set to true also in case of ts extension.
Added an if case to set this to false for ts, and leave it to true for jsx.

[rubenv]

Do you have an example of a file that breaks? We have unit tests that verify a plain .ts file, so things should work.

[rubenv]

For example: https://github.com/rubenv/angular-gettext-tools/blob/master/test/fixtures/ts.ts

Tested here:

angular-gettext-tools/test/extract_extensions.js

Lines 111 to 125 in ff2337e

	it('supports TypeScript files', function () {
	var files = [
	'test/fixtures/ts.ts'
	];
	var catalog = testExtract(files);
	assert.equal(catalog.items.length, 2);
	assert.equal(catalog.items[0].msgid, 'Hello');
	assert.equal(catalog.items[0].msgstr, '');
	assert.deepEqual(catalog.items[0].references, ['test/fixtures/ts.ts:2']);
	assert.equal(catalog.items[1].msgid, 'One\nTwo\nThree');
	assert.equal(catalog.items[1].msgstr, '');
	assert.deepEqual(catalog.items[1].references, ['test/fixtures/ts.ts:3']);
	});

[IvanoAlvino]

This fixes the following reported error #181
We experienced the same problem, and we are locally able to fix it by setting jsx = false for ts files.

Can you please try with the following file?

angular.module("myApp").controller("helloController", (gettext) => {
	const castedVar: any = <any> gettext("Hello");
	gettext(); // Should be ignored.
});

[rubenv]

Yes, that seems to be the problem. Could you please add that to the test fixture and unit test? That way we're sure it never breaks again.

Also, instead of adding an extra if/else case, you could just write this:

            if (extension === 'ts' || extension === 'tsx') {
                syntax = tsParser.parse(src, {
                    sourceType: 'module',
                    comment: true,
                    ecmaFeatures: {
                        jsx: extension === 'tsx'
                    }
                });
            } else {

Thanks for submitting this!

[IvanoAlvino]

Sure sounds good, fixes are coming :)

[rubenv]

Excellent fix, can go in now that we've got a test case.

[IvanoAlvino]

Thanks for being very quick about this! :)
Have a nice day!

[rubenv]

Released to NPM as v2.3.12. Thanks a lot!