Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extraction support for translatePlural filter #45

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add extraction support for translatePlural filter #45

wants to merge 7 commits into from

Conversation

pswai
Copy link

@pswai pswai commented Nov 7, 2014

This adds support to extract strings from translatePlural filter.

This is together with rubenv/angular-gettext#122

rubenv
rubenv reviewed Nov 7, 2014
View reviewed changes
test/extract.coffee
catalog = testExtract(files)

# Notes on the ordering: Strings seem to be sorted alphabetically
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's by design.

@rubenv
Copy link
Owner

rubenv commented Nov 7, 2014

Really good stuff. If we can make the {{$count}} placeholder work, I'd love to see it used here as well. Apart from that no real remarks.

We still need documentation, but we can add that later on.

@rubenv rubenv added this to the 2.1 - Plural filters milestone Dec 8, 2014
@rubenv rubenv mentioned this pull request Dec 8, 2014
Open
1 task
@Alir3z4
Copy link

Alir3z4 commented May 21, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1 - Plural filters
Development

Successfully merging this pull request may close these issues.
3 participants
@pswai @rubenv @Alir3z4