-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider #140
base: master
Are you sure you want to change the base?
Provider #140
Conversation
string = context ? $interpolate(string)(context) : string; | ||
return addTranslatedMarkers(string); | ||
}, | ||
angular.extend(this, provider); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain what is going on here? I'm not exactly sure I understand what this does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an Angular provider definition, this
is the provider. So when we extend this
we're adding fields onto the provider. this.$get
is a special function that returns the service. The service is just the provider plus some extra functions that don't make sense in the provider since services like $http
aren't available yet.
b32ca30
to
e7b10ef
Compare
Will this be merged at some point? I need to translate some data I pass to the UI Router which is initialized in the config phase. |
I'd be interested in the status of this issue too. Came here from #138 |
I hope this PR is merged after resolving conflicts. |
+1 |
Interesting...I was just about implementing this just because of the same reason as @smehrbrodt pointed. @rubenv Any plans on merging this in the near future? |
+1 - Also need this for translating URLs defined in the config stage and would love this to be merged |
+1 is there a reason this hasn't been merged yet? |
+1 - Need to translate intercepted server responses |
Implement most functionality of
gettextCatalog
as a provider. This allows clients to injectgettextCatalogProvider
into theconfig
phase of Angular's lifecycle.