Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get correct plural when n is in string #315

Closed
wants to merge 1 commit into from

Conversation

zhuangya
Copy link

ref #313 fix #305

@zhuangya
Copy link
Author

zhuangya commented Oct 8, 2016

🤔 anyone?

@duall
Copy link

duall commented Oct 12, 2016

+1

@rubenv
Copy link
Owner

rubenv commented Oct 19, 2016

As mentioned in #275, I'd rather not merge this. Make sure your data is good before it arrives at angular-gettext.

JS might not be strongly-typed, but that doesn't mean that types don't matter. Strings aren't numbers, the only person who knows if a conversion can be done safely is you.

@rubenv rubenv closed this Oct 19, 2016
@zhuangya
Copy link
Author

Make sure your data is good before it arrives at angular-gettext.

so you're telling me, every single time i use angular-gettext with input(type=range), i need something like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singular only shows well the first time
3 participants