Merge pull request #46 from tagliala/chore/provide-examples-for-assoc…

…iation-style-with-traits

Add an example for an association with factory

docs/modules/ROOT/pages/cops_factorybot.adoc

@@ -35,6 +35,16 @@ end
 factory :post do
   user
 end
+
+# bad
+factory :post do
+  association :user, :author
+end
+
+# good
+factory :post do
+  user factory: %i[user author]
+end
 ----
 
 ==== EnforcedStyle: explicit
@@ -51,6 +61,16 @@ factory :post do
   association :user
 end
 
+# bad
+factory :post do
+  user factory: %i[user author]
+end
+
+# good
+factory :post do
+  association :user, :author
+end
+
 # good (NonImplicitAssociationMethodNames: ['email'])
 sequence :email do |n|
   "person#{n}@example.com"

lib/rubocop/cop/factory_bot/association_style.rb

@@ -21,6 +21,16 @@ module FactoryBot
       #     user
       #   end
       #
+      #   # bad
+      #   factory :post do
+      #     association :user, :author
+      #   end
+      #
+      #   # good
+      #   factory :post do
+      #     user factory: %i[user author]
+      #   end
+      #
       # @example EnforcedStyle: explicit
       #   # bad
       #   factory :post do
@@ -32,6 +42,16 @@ module FactoryBot
       #     association :user
       #   end
       #
+      #   # bad
+      #   factory :post do
+      #     user factory: %i[user author]
+      #   end
+      #
+      #   # good
+      #   factory :post do
+      #     association :user, :author
+      #   end
+      #
       #   # good (NonImplicitAssociationMethodNames: ['email'])
       #   sequence :email do |n|
       #     "person#{n}@example.com"