Don't use test-queue
to run tests on JRuby because it doesn't support fork
#296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #294
Currently this is aimed at being the most straightforward if probably slightly inelegant way to get tests running on JRuby - I assume there is probably a slightly cleaner way of invoking tests but I don't yet know what it is and
Rake::TestTask
was more than a few lines of code 😅I think it would be worth considering having
test-queue
"support" JRuby by not usingfork
if that platform is detected or if you setTEST_QUEUE_WORKERS
to 1 (or maybe 0?) as a way of making it easier to have a normalized way of invoking tests across different platforms like this; but it would also be equally valid I think fortest-queue
to say that's out of scope for the gem🤷Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.Added an entry (file) to the changelog folder named{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.