Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to add socket_class while instantiating net_ldap connection #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ability to add socket_class while instantiating net_ldap connection #356

wants to merge 1 commit into from

Conversation

dhivyada
Copy link

No description provided.

jethrodaniel
jethrodaniel reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@jethrodaniel jethrodaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net-ldap-0.16.2.gem was accidentally committed

@dhivyada
Copy link
Author

Removed the accidentally committed gem. Thank you for the feedback

@dhivyada
Copy link
Author

@jethrodaniel : Force pushed the socket changes alone to keep the commit history clean

@michaelfranzl
Copy link

This is a very useful feature IMO. This would allow a socket to be configured beyond the connection timeout, e.g. by binding it to a specific local interface and port. Are there plans to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jethrodaniel jethrodaniel jethrodaniel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhivyada @michaelfranzl @jethrodaniel