-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored parse_signature #61
base: master
Are you sure you want to change the base?
Conversation
Hey, wait a minute. I think I made a mistake. |
You modified the regular expressions, from |
Fixed. |
I guess you need to propagate |
Yes, I think you're right. Anyway, thank you again. |
I went back to work on the monkey patch one more time, but it wouldn't work without passing the tymap 🤦 |
Could you show a signature you want to parse? |
An example: |
Yes, thanks. |
Idea: We use It may be a good idea that we use |
Hi fiddle developers.
This is just an idea.
A proposal to improve the parse_signature method.
Background:
I wanted to parse_signature recursively when the argument was a function (i.e. a function pointer).
When I wrote a monkey patch for it, I noticed that parse_signature was unnecessarily complicated.
2 - 4 are more of a library-wide issue, and are my personal opinions rather than objective facts.
Each library has its own history.
Here, I am focusing on 1.
If you think the pull request is not good, just close it.
Thank you.