ActiveSupport String inflections #593
Conversation
|
@hibariya Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
$ bundle exec rbs diff --detail --format diff --type-name String --before gems/activesupport/6.0 --after 593
- [::String public] def safe_constantize: () -> untyped
+ [::String public] def safe_constantize: () -> untyped?
- [::String public] def titleize: (?keep_id_suffix: bool keep_id_suffix) -> untyped
+ [::String public] def titleize: (?keep_id_suffix: ::boolish) -> ::String
- [::String public] def demodulize: () -> untyped
+ [::String public] def demodulize: () -> ::String
- [::String public] def deconstantize: () -> untyped
+ [::String public] def deconstantize: () -> ::String
- [::String public] def parameterize: (?locale: untyped? locale, ?preserve_case: bool preserve_case, ?separator: ::String separator) -> untyped
+ [::String public] def parameterize: (?separator: ::String, ?preserve_case: ::boolish, ?locale: ::Symbol) -> ::String
- [::String public] def tableize: () -> untyped
+ [::String public] def tableize: () -> ::String
- [::String public] def classify: () -> untyped
+ [::String public] def classify: () -> ::String
- [::String public] def humanize: (?keep_id_suffix: bool keep_id_suffix, ?capitalize: bool capitalize) -> untyped
+ [::String public] def humanize: (?capitalize: ::boolish, ?keep_id_suffix: ::boolish) -> ::String
- [::String public] def upcase_first: () -> untyped
+ [::String public] def upcase_first: () -> ::String
- [::String public] def foreign_key: (?bool separate_class_name_and_id_with_underscore) -> untyped
+ [::String public] def foreign_key: (?::boolish separate_class_name_and_id_with_underscore) -> ::String |
| def underscore: () -> String | ||
| def dasherize: () -> String | ||
| def pluralize: (?Integer | Symbol? count, ?Symbol locale) -> String | ||
| def singularize: (?Symbol locale) -> String | ||
| def constantize: () -> untyped | ||
| def safe_constantize: () -> untyped? |
There was a problem hiding this comment.
Since untyped includes all types, it makes no sense to make it optional.
How about to use Module??
There was a problem hiding this comment.
Good point 🙏 I'll remove the ? at least.
| def underscore: () -> String | ||
| def dasherize: () -> String | ||
| def pluralize: (?Integer | Symbol? count, ?Symbol locale) -> String | ||
| def singularize: (?Symbol locale) -> String | ||
| def constantize: () -> untyped |
There was a problem hiding this comment.
@ksss Thanks for taking a look Yuki san! Yeah, I thought about it as well 👍 but noticed that it actually could be anything. For example, 'RUBY_VERSION'.constantize will be a string. Also, its value should basically the same as the value of Module#const_get. That's why I left these return values alone.
ActiveSupport String inflections
No description provided.