Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: ActiveModel::Serialization#send and ActiveModel::Validations#send #595

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

rhiroe
Copy link
Contributor

@rhiroe rhiroe commented Jun 11, 2024

Passing a Symbol argument to these methods will result in an error.

Cannot pass a value of type `::Symbol` as an argument of type `::String`
  ::Symbol <: ::String
    ::Object <: ::String
      ::BasicObject <: ::String(Ruby::ArgumentTypeMismatch)

Also, these methods do not exist.

2e17636
It appears to have been added by this commit, but appears to work fine without it now.

…send

Passing a Symbol argument to these methods will result in an error.

```
Cannot pass a value of type `::Symbol` as an argument of type `::String`
  ::Symbol <: ::String
    ::Object <: ::String
      ::BasicObject <: ::String(Ruby::ArgumentTypeMismatch)
```

Also, these methods do not exist.

ruby@2e17636
It appears to have been added by this commit, but appears to work fine without it.
@rhiroe rhiroe marked this pull request as ready for review June 11, 2024 06:01
Copy link

@rhiroe Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activemodel

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@rhiroe
Copy link
Contributor Author

rhiroe commented Jun 12, 2024

/merge

@github-actions github-actions bot merged commit 999dcca into ruby:main Jun 12, 2024
5 checks passed
@rhiroe rhiroe deleted the remove/activemodel-patch branch June 12, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants